Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tech-debt: Update submodule, e2e tests #1388

Merged
merged 1 commit into from
Dec 21, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .circleci/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ jobs:
go_version:
type: string
environment:
CI_E2E_FILENAME: "faab6dcf/rel-nightly"
CI_E2E_FILENAME: "fa6ad40d/rel-nightly"
steps:
- go/install:
version: << parameters.go_version >>
Expand Down
15 changes: 2 additions & 13 deletions e2e_tests/src/e2e_common/util.py
Original file line number Diff line number Diff line change
Expand Up @@ -164,18 +164,6 @@ def firstFromS3Prefix(
haystack = []
found_needle = False

def report():
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you...I hated this message

print(
f"""Hello from firstFromS3Prefix() !!!!
I finished searching for the needle {desired_filename} in the AWS S3 path {bucket}/{prefix}.
haystack={haystack}
len(haystack)={len(haystack)}
found_needle={found_needle}
"""
)

atexit.register(report)

response = s3.list_objects_v2(Bucket=bucket, Prefix=prefix, MaxKeys=100)
if (not response.get("KeyCount")) or ("Contents" not in response):
raise Exception("nothing found in s3://{}/{}".format(bucket, prefix))
Expand All @@ -193,7 +181,8 @@ def report():
found_needle = True
break

logger.warning("file not found in s3://{}/{}".format(bucket, prefix))
if not found_needle:
logger.warning("file {} not found in s3://{}/{}".format(desired_filename, bucket, prefix))
return found_needle


Expand Down
2 changes: 1 addition & 1 deletion third_party/go-algorand
Submodule go-algorand updated 207 files