Release preparation: Feature flag to disable configurable api parameters. #917
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
winder
commented
Mar 9, 2022
| @@ -77,7 +77,7 @@ func TestSchemaCheck(t *testing.T) { | |||
| type testingStruct struct { | |||
| name string | |||
| ddm *DisplayDisabledMap | |||
| expectError string | |||
| expectError []string | |||
There was a problem hiding this comment.
This was flaky because the error string is generated according to maps being returned in a randomized order. So sometimes the tests with 2 values were swapped in the error string.
winder
force-pushed
the
will/params-feature-flag
branch
from
e1df1bf
to
badc5b2
Compare
Codecov Report
@@ Coverage Diff @@
## develop #917 +/- ##
===========================================
- Coverage 57.98% 57.94% -0.05%
===========================================
Files 40 40
Lines 4706 4713 +7
===========================================
+ Hits 2729 2731 +2
- Misses 1642 1646 +4
- Partials 335 336 +1
Continue to review full report at Codecov.
|
AlgoStephenAkiki
approved these changes
Mar 10, 2022
winder
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Disable this feature for the next release.