DO NOT MERGE: indexer 2.10.0 #923
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…#888) Default to including Python go-algorand E2E tests in `buildtestdata.sh.` * Prior to the PR, `buildtestdata.sh` did not include go-algorand E2E tests. The PR closes the test coverage gap. * Additionally, exposes an environment variable to simplify user control of included tests. The exposed configuration improves workflows for local testing on select tests.
#888 introduces a bug due to bash's ordering of brace and parameter expansion. The commit supports parameter expansion at the expense of dropping the environment variable. I'll restore external configuration in a subsequent PR.
This reverts commit 0b6d814.
* Disable Parameters in REST API Resolves #3582 Puts in the infrastructure and disables certain parameters in the REST API for poor performing queries. * PR comments
*add monitoring dashboard
* Allow Viewing of Disabled Params Resolves #3583 Add a new subcommand "algorand-indexer api-config" to show current config * Mod file * PR comments * PR comments
* Init * Enable Validation and Acceptance of New Parameter Configuration Resolves #3584 - Allows for the supplying of configuration files for the daemon and api-config subcommands. - Properly validates the schema and contents of the supplied config file - Enables default parameters to be disabled, allows integration tests to run with all parameters enabled * Removed reflect deep equal for unit test * Changed expectError to a string from a boolean * Added checking of supplied file with enable all params
Co-authored-by: John Lee <[email protected]> Co-authored-by: Brice Rising <[email protected]> Co-authored-by: Tolik Zinovyev <[email protected]> Co-authored-by: Barbara Poon <[email protected]> Co-authored-by: Will Winder <[email protected]>
yaovi-a
approved these changes
Mar 14, 2022
algochoi
approved these changes
Mar 14, 2022
Co-authored-by: chris erway <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #923 +/- ##
==========================================
+ Coverage 59.07% 59.21% +0.13%
==========================================
Files 37 42 +5
Lines 4430 5720 +1290
==========================================
+ Hits 2617 3387 +770
- Misses 1499 1896 +397
- Partials 314 437 +123
Continue to review full report at Codecov.
|
algojack
approved these changes
Mar 21, 2022
|
it seems circleci was unable to report success back to github. (Maybe github was having issues? maybe circleci?) but it is successful as far as i can tell) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's New
Important Note
A database migration is included in this release. This has been timed to a few minutes on testnet, and about half an hour for mainnet (on a db.r5.xlarge RDS instance). We recommend running this upgrade in a non-live environment to allow the migration to finish before putting in service.
Changelog
Additional Resources