Fix dev mode by addressing off by one error. #920
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlgoStephenAkiki
approved these changes
Mar 10, 2022
shiqizng
reviewed
Mar 10, 2022
shiqizng
approved these changes
Mar 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
"StatusAfterBlock" needs to be given the current round in order to wait for the next round. Because we give it the next round, it waits until the round after the next round. This adds unnecessary latency and breaks entirely when dev mode is enabled and there is no next round to keep flushing the latest changes.
Thanks to @achidlow for the suggestion.
Test Plan
Existing integration tests start a network and use this code.