Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip validator errors resulting from the account resource limit. #974

Merged
merged 2 commits into from
Apr 28, 2022

Conversation

winder
Copy link
Contributor

@winder winder commented Apr 25, 2022

Summary

Do not generate errors if validator detects a mismatch between algod and indexer due to the account resource limit.

Test Plan

Manual testing.

$ ./validator --algod-token _ --indexer-token _ --indexer-url "" --algod-url "" --addr IACII2KW5LSVKZKSJ5MMC77745CSVROOV47CEZQ7K75Q7TFKWXK5HNCK5Q 2>err.log

0        : _

Number of errors: [0 / 1]
Skipped (account-limit): 1
Retry count: 0
Checks per second: 1.701474
Test duration: 00:00:00
$ cat err.log 
===================================================================
2022-04-25 11:34:30 AM
Account: IACII2KW5LSVKZKSJ5MMC77745CSVROOV47CEZQ7K75Q7TFKWXK5HNCK5Q
Error #: 0
Retries: 0
Rounds Match: false
Address skipped: too many asset and/or accounts to return

@tolikzinovyev
Copy link
Contributor

Why not increase the limit when validating?

@winder
Copy link
Contributor Author

winder commented Apr 26, 2022

Why not increase the limit when validating?

That would also be good, and this change wouldn't prevent doing that as well. Regardless of whether or not the server is suitably configured, this change means the report is not going to have false positives. Whether or not anything was skipped (and which accounts were skipped) is included in the report / error log.

@winder winder self-assigned this Apr 26, 2022
@winder winder merged commit 18f48f0 into algorand:develop Apr 28, 2022
@winder winder deleted the will/skip-limit-errors branch April 28, 2022 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants