Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DO NOT MERGE: indexer 2.11.0 #984

Merged
merged 28 commits into from
May 3, 2022
Merged

DO NOT MERGE: indexer 2.11.0 #984

merged 28 commits into from
May 3, 2022

Conversation

Algo-devops-service
Copy link
Contributor

@Algo-devops-service Algo-devops-service commented Apr 29, 2022 •
edited by algobarb
Loading

GitHub Logo

Important Notes

Highlights

Configuring Query Parameters

https://github.com/algorand/indexer/blob/develop/docs/DisablingParametersGuide.md

Changelog

New Features

  • Make configurable parameter flags visible. (#959)
  • Add --error-log-file validator option. (#975)
  • Consider TxType when selecting transaction amount currency type. (#935)

Enhancements

  • Tests: Elaboration on system configuration for E2E tests (#921)
  • Add documentation for configuring query parameters. (#931)
  • New block fetcher unit tests. (#967)
  • Update documentation to reflect automated e2e test artifacts. (#956)
  • Add vacuum documentation. (#957)
  • Cleanup README, add index management section, clarify transaction result order. (#958)
  • Nightly job improvements (#945)
  • Use external docker container to speed up tests. (#948)
  • Add golangci-lint to CI. (#947)
  • Tests: remove ghosts of past discrepancies in parity test (#924)
  • Update parity job to focus on account. (#979)

Bugfixes

  • Fix hashes file extension (#922)
  • Don't assume /v2/accounts asset-id parameter should override exclude parameter (#977)
  • Skip validator errors resulting from the account resource limit. (#974)
  • Fix race condition by calling Rollback before close when processing results. (#965)
  • Do not show block not found error after fetcher has finished catchup. (#966)
  • Ensure block-generator service shutdown after failure. (#937)
  • validator: skip comparison of deleted accounts. (#987)

Other

  • Update indirect go module. (#932)

Additional Resources

tzaffi and others added 25 commits March 11, 2022 06:48
@tzaffi
Remove ghosts of past discrepancies in parity test (#924)
6618180
@algobarb
Fix hashes file extension (#922)
e2d9e67 
* Replace period in extensions with underscores
@AlgoStephenAkiki
Update indirect go module. (#932)
52d2d89
@AlgoStephenAkiki
Add documentation for configuring query parameters. (#931)
1914606
@algoidurovic @michaeldiamant
Tests: Elaboration on system configuration for E2E tests (#921)
63c41f9 
* Tests: Elaboration on system configuration for E2E tests

I experienced some issues following these steps so I added a help section in case the errors are encountered by others.
Tested locally.

* Update misc/README.md

Co-authored-by: Michael Diamant <[email protected]>

* Update misc/README.md

Co-authored-by: Michael Diamant <[email protected]>

* Update README.md

* Update README.md

Co-authored-by: Michael Diamant <[email protected]>
@winder
Ensure block-generator service shutdown after failure. (#937)
9bea6c2
@algojohnlee
Merge branch 'develop' into release/2.10.0
f58987b
@algojohnlee
Merge pull request #941 from algorand/release/2.10.0
bb83295 
indexer 2.10.0-remerge
@winder
Consider TxType when selecting transaction amount currency type. (#935)
99ab66f
@shiqizng
Add golangci-lint to CI. (#947)
ac25054
@winder
Use external docker container to speed up tests. (#948)
4835748
@tzaffi @algojack
Nightly job improvements. (#945)
762d0ca 
Co-authored-by: Jack Smith <[email protected]>
@winder
Cleanup README, add index management section, clarify transaction res…
e472383 
…ult order. (#958)
@AlgoStephenAkiki
Make configurable parameter flags visible. (#959)
514587e
@shiqizng
Add vacuum documentation. (#957)
27a7bb4
@AlgoStephenAkiki
Update documentation to reflect automated e2e test artifacts. (#956)
aef1368
@Eric-Warehime
Do not show block not found error after fetcher has finished catchup. (…
32927e1 
…#966)
@AlgoStephenAkiki
Fix race condition by calling Rollback before close when processing r…
7751245 
…esults. (#965)
@Eric-Warehime
New block fetcher unit tests. (#967)
9b93cc3
@winder
Skip validator errors resulting from the account resource limit. (#974)
18f48f0
@cce
Don't allow /v2/accounts?asset-id to override ?exclude= parameter (#977)
7c7c696
@winder
Add --error-log-file validator option. (#975)
bf95228
@tzaffi
Update parity job to focus on account. (#979)
3406841
@algobarb
CICD: Update build docker run command (#983)
09d34f4 
* add safe directory workaround

* make it use * wildcard

* be a little more specific for the safe.directory

* switch back to *
@Algo-devops-service
Bump version to 2.11.0-rc1
62489ad
@algobarb algobarb self-assigned this Apr 29, 2022
@codecov-commenter
Copy link

codecov-commenter commented May 2, 2022 •
edited
Loading

Codecov Report

Merging #984 (8a9da1c) into master (46a1099) will increase coverage by 0.96%.
The diff coverage is 14.28%.

@@            Coverage Diff             @@
##           master     #984      +/-   ##
==========================================
+ Coverage   59.21%   60.17%   +0.96%     
==========================================
  Files          42       41       -1     
  Lines        5720     5700      -20     
==========================================
+ Hits         3387     3430      +43     
+ Misses       1896     1824      -72     
- Partials      437      446       +9
Impacted Files Coverage Δ
api/error_messages.go 100.00% <ø> (ø)
api/generated/v2/routes.go 18.92% <ø> (ø)
api/handlers.go 74.31% <0.00%> (ø)
fetcher/fetcher.go 33.53% <ø> (+33.53%) ⬆️
idb/postgres/postgres.go 59.98% <0.00%> (-1.22%) ⬇️
api/converter_utils.go 92.18% <100.00%> (ø)
util/diff.go

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 46a1099...8a9da1c. Read the comment docs.

tzaffi
tzaffi approved these changes May 2, 2022
View reviewed changes
Copy link
Contributor

@tzaffi tzaffi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Algo-devops-service Algo-devops-service merged commit 5648d0a into master May 3, 2022
@algobarb algobarb deleted the release/2.11.0 branch May 4, 2022 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlgoStephenAkiki AlgoStephenAkiki AlgoStephenAkiki approved these changes

@tzaffi tzaffi tzaffi approved these changes

@winder winder Awaiting requested review from winder

@algojack algojack Awaiting requested review from algojack

@chaihoang chaihoang Awaiting requested review from chaihoang

@egieseke egieseke Awaiting requested review from egieseke

@onetechnical onetechnical Awaiting requested review from onetechnical

@shiqizng shiqizng Awaiting requested review from shiqizng

Assignees

@algobarb algobarb

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.