Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support setting flush interval of the metric log via SentinelConfig property #1867

Closed
yaoyuandota opened this issue Nov 19, 2020 · 3 comments
Closed

Support setting flush interval of the metric log via SentinelConfig property #1867

yaoyuandota opened this issue Nov 19, 2020 · 3 comments
Labels
area/configuration Issues or PRs related to configurations of Sentinel area/metrics Issues or PRs related to metrics and monitoring good first issue Good for newcomers

Comments

@yaoyuandota
Copy link

您好，我们公司使用sentinel做限流监控，不过metric功能和dashborad有自己的体系，发现metric功能会占用大量内存
180个资源，MetricNode就占用了200M， 虽然这个MetricNode可以gc掉，但是对与我们来说是浪费了。
请问下是不是 重新写下 FlowRuleManager 删除sentinel-metrics-record-task这个定时任务是最方便关闭metric功能的方式
@sczyh30 sczyh30 added the kind/question Category issues related to questions or problems label Nov 23, 2020
@sczyh30 sczyh30 changed the title 何如屏蔽Metric功能 Support setting flush interval of the metric log via SentinelConfig property Dec 18, 2020
@sczyh30
Copy link
Member

sczyh30 commented Dec 18, 2020

We may add an attribute csp.sentinel.metric.flush.interval to control the flush interval of the metric log. When the interval = 0, the metric log task will not be started (thus disabled). Discussions and contributions are welcomed!

@sczyh30 sczyh30 added area/configuration Issues or PRs related to configurations of Sentinel good first issue Good for newcomers area/metrics Issues or PRs related to metrics and monitoring and removed kind/question Category issues related to questions or problems labels Dec 18, 2020
@brotherlu-xcq
Copy link
Collaborator

I will try to add the attribute to support the custom interval of metric. need we also support the custom time unit ?
image
@sczyh30

This was referenced Dec 19, 2020
Merged
Closed
@sczyh30
Copy link
Member

sczyh30 commented Mar 9, 2021

Resolved via #1919 (released in 1.8.1)

@sczyh30 sczyh30 closed this as completed Mar 9, 2021
@brotherlu-xcq brotherlu-xcq mentioned this issue Jun 22, 2021
Closed
CST11021 pushed a commit to CST11021/Sentinel that referenced this issue Nov 3, 2021
@RongtongJin
Merge pull request alibaba#1867 from 9526xu/fix-transaction-doc
549f72f 
[ISSUE alibaba#1866] Fix transaction message doc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/configuration Issues or PRs related to configurations of Sentinel area/metrics Issues or PRs related to metrics and monitoring good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@sczyh30 @brotherlu-xcq @yaoyuandota