Support setting flush interval of the metric log via SentinelConfig property #1919
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sczyh30
added
area/configuration
sczyh30
reviewed
Dec 28, 2020
sentinel-core/src/main/java/com/alibaba/csp/sentinel/slots/block/flow/FlowRuleManager.java
Outdated
Show resolved
Hide resolved
|
@sczyh30 I have change the code as we discussed. |
|
Nice work. Thanks for contributing! |
shenbaoyong
pushed a commit
to shenbaoyong/Sentinel
that referenced
this pull request
Feb 5, 2021
hughpearse
pushed a commit
to hughpearse/Sentinel
that referenced
this pull request
Jun 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…roperty
Describe what this PR does / why we need it
add a new feature to support control the flush interval of metric via sentinel config:
csp.sentinel.metric.flush.intervalDoes this pull request fix one issue?
Fixs 1867
Describe how you did it
add a new property in sentinel config(
csp.sentinel.metric.flush.interval). control the metic timer start via this config.Describe how to verify it
change the config value, see the metric log file output and use jvm tool to see if the timer thread is started.
Special notes for reviews