-
Notifications
You must be signed in to change notification settings - Fork 8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prometheus metric extension #735
Conversation
Signed-off-by: Carpenter Lee <[email protected]>
Signed-off-by: Carpenter Lee <[email protected]>
Signed-off-by: Carpenter Lee <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #735 +/- ##
============================================
+ Coverage 41.04% 41.36% +0.31%
- Complexity 1338 1349 +11
============================================
Files 301 302 +1
Lines 8630 8682 +52
Branches 1159 1159
============================================
+ Hits 3542 3591 +49
- Misses 4663 4666 +3
Partials 425 425
Continue to review full report at Codecov.
|
Related to #211 |
Has there been any progress in this matter? |
|
Hi, @CarpenterLee |
Hi, @sczyh30 ! Is my request(#1566 ) closed? Issue Description Describe what happened (or what feature you want) Take the method[addPass(String resource, int n, Object... args)] for example. So I think I need a feature replacing the input String parameter[resource] with the below class type: com.alibaba.csp.sentinel.slotchain.ResourceWrapper |
This PR is outdated. New PRs are welcomed! |
Enhancement/advanced metric extension tagging entrytype #1609 raised for the feature request#1566 |
I have try this way to send Metric to prometheus, but i can't find metics like sentinel_pass_requests_total in http://localhost:9527/actuator/prometheus. |
Signed-off-by: Carpenter Lee [email protected]
Describe what this PR does / why we need it
Sentinel real-time statistics are useful for system monitoring. #730 adds extension interface to Sentinel internal statistics, which provides an implementation independent way to get Sentinel statistics.
This PR provides Prometheus backend implementation of
MetricExtension
.Does this pull request fix one issue?
NONE
Describe how you did it
Provides Prometheus backend implementation of
MetricExtension
.Describe how to verify it
Run test cases.
Special notes for reviews