Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix grpc-adapter bug,replace the Entry by AsyncEntry #289 #291

Merged
merged 2 commits into from
Aug 14, 2019

Conversation

CodingSinger
Copy link
Contributor

Describe what this PR does / why we need it

fix the bug and perfect the grpc-adapter ,replace the Entry by AsyncEntry

Does this pull request fix one issue?

Fixes #289

Describe how you did it

Describe how to verify it

Special notes for reviews

@CLAassistant
Copy link

CLAassistant commented Dec 7, 2018

CLA assistant check
All committers have signed the CLA.

@codecov-io
Copy link

codecov-io commented Dec 7, 2018

Codecov Report

Merging #291 into master will increase coverage by 4.05%.
The diff coverage is 74.28%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #291      +/-   ##
============================================
+ Coverage     41.71%   45.77%   +4.05%     
+ Complexity     1376      917     -459     
============================================
  Files           304      181     -123     
  Lines          8764     5757    -3007     
  Branches       1182      830     -352     
============================================
- Hits           3656     2635    -1021     
+ Misses         4662     2791    -1871     
+ Partials        446      331     -115
Impacted Files Coverage Δ Complexity Δ
...el/adapter/grpc/SentinelGrpcClientInterceptor.java 87.87% <69.23%> (+11.21%) 4 <1> (ø) ⬇️
...el/adapter/grpc/SentinelGrpcServerInterceptor.java 76.66% <77.27%> (-5.16%) 4 <2> (ø)
...ain/java/com/alibaba/csp/sentinel/util/IdUtil.java 0% <0%> (-100%) 0% <0%> (-6%)
.../sentinel/adapter/dubbo/DubboAppContextFilter.java 0% <0%> (-100%) 0% <0%> (-3%)
...sp/sentinel/adapter/dubbo/AbstractDubboFilter.java 0% <0%> (-100%) 0% <0%> (-4%)
...alibaba/csp/sentinel/adapter/dubbo/DubboUtils.java 0% <0%> (-66.67%) 0% <0%> (-2%)
...nel/adapter/dubbo/SentinelDubboProviderFilter.java 0% <0%> (-64%) 0% <0%> (-2%)
...nel/adapter/dubbo/SentinelDubboConsumerFilter.java 0% <0%> (-57.15%) 0% <0%> (-2%)
...ntinel/slots/block/flow/param/ParameterMetric.java 23.33% <0%> (-51.67%) 7% <0%> (-22%)
...va/com/alibaba/csp/sentinel/init/InitExecutor.java 12.82% <0%> (-47.71%) 2% <0%> (-4%)
... and 285 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 062385f...d0ac442. Read the comment docs.

Copy link
Member

@sczyh30 sczyh30 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sczyh30 sczyh30 added the area/integrations Issues or PRs related to integrations with open-source components label Aug 14, 2019
@sczyh30 sczyh30 merged commit b2ff4b7 into alibaba:master Aug 14, 2019
@sczyh30
Copy link
Member

sczyh30 commented Aug 14, 2019

Thanks for contributing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/integrations Issues or PRs related to integrations with open-source components size/L Indicate a PR that changes 100-499 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] grpc adapter-Tracer.trace() can't success
4 participants