-
Notifications
You must be signed in to change notification settings - Fork 8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix dubbo maven dependency in sentinel-dubbo-demo #534
Conversation
…y, and remove spring-context 5.0.7.RELEASE dependency
Codecov Report
@@ Coverage Diff @@
## master #534 +/- ##
===========================================
+ Coverage 37.69% 37.99% +0.3%
- Complexity 1102 1111 +9
===========================================
Files 259 259
Lines 8174 8177 +3
Branches 1113 1115 +2
===========================================
+ Hits 3081 3107 +26
+ Misses 4695 4666 -29
- Partials 398 404 +6
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
👍 Thanks! |
Describe what this PR does / why we need it
Dubbo demo run failure.
Does this pull request fix one issue?
Fixes #530
Describe how you did it
Add dependency that needed for dubbo 2.6.5:
spring-context-support
1.0.2 forAnnotationInjectedBeanPostProcessor
, indubbo-config-spring
which is optional.netty-all
4.1.31.Final for dubbo-qos, indubbo-qos
which is optional.Remove
spring-context
as dubbo.jar depends it.@see
apache/dubbo#2869
Describe how to verify it
Run demo, start FooProviderBootstrap and FooConsumerBootstrap.
Special notes for reviews
Dubbo 2.6.6 may released next week, waiting it release, we can upgrade from 2.6.5 to 2.6.6,
as it fixes
UndeclaredThrowableException
issue in consumer side when catch Exception.@see
apache/dubbo#3386
As Dubbo 2.7.0 need JDK1.8, another demo module may be considered in the future.