Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix dubbo maven dependency in sentinel-dubbo-demo #534

Merged
merged 3 commits into from
Mar 6, 2019
Merged

Fix dubbo maven dependency in sentinel-dubbo-demo #534

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
55bcb7b
add spring-context-support 1.0.2 and netty-all 4.1.31.Final dependenc…
cdfive Mar 2, 2019
727387d
Add comment for dependency
cdfive Mar 6, 2019
8b3ac2f
improve comment, modify dubbo-config to dubbo-config-spring
cdfive Mar 6, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 21 additions & 5 deletions sentinel-demo/sentinel-demo-dubbo/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,16 +12,32 @@
<artifactId>sentinel-demo-dubbo</artifactId>

<dependencies>
<dependency>
<groupId>org.springframework</groupId>
<artifactId>spring-context</artifactId>
<version>5.0.7.RELEASE</version>
</dependency>
<!-- Demo use dubbo 2.6.5, since it supports jdk1.6 -->
<dependency>
<groupId>com.alibaba</groupId>
<artifactId>dubbo</artifactId>
<version>2.6.5</version>
</dependency>

<!-- As dubbo provide qos plugin since 2.5.8 and is enable by default -->
<!-- The dubbo-qos module is optional and it depends netty4, so add it explicitly -->
<!-- @see http://dubbo.apache.org/zh-cn/docs/user/references/qos.html -->
<dependency>
sczyh30 marked this conversation as resolved.
Show resolved Hide resolved
<groupId>io.netty</groupId>
<artifactId>netty-all</artifactId>
<version>4.1.31.Final</version>
</dependency>

<!-- As demo use @DubboComponentScan to config, which is implemented in dubbo-config-spring module -->
<!-- The dubbo-config-spring module is optional and it depends spring-context-support, so add it explicitly-->
<!-- @see https://github.com/apache/incubator-dubbo/issues/2869 -->
<dependency>
<groupId>com.alibaba.spring</groupId>
<artifactId>spring-context-support</artifactId>
<version>1.0.2</version>
</dependency>

<!-- sentinel adapter and transport -->
<dependency>
<groupId>com.alibaba.csp</groupId>
<artifactId>sentinel-dubbo-adapter</artifactId>
Expand Down