Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dashboard: fix a request mapping issue of removing machines api #559

Merged
merged 1 commit into from
Mar 8, 2019

Conversation

jasonjoo2010
Copy link
Collaborator

Describe what this PR does / why we need it

The api {app}/machine/remove.json is called through GET in old version but it changed to POST now and definition of the mapping was not changed together.

@codecov-io
Copy link

codecov-io commented Mar 8, 2019

Codecov Report

Merging #559 into master will decrease coverage by 0.36%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #559      +/-   ##
============================================
- Coverage     38.68%   38.31%   -0.37%     
+ Complexity     1166     1159       -7     
============================================
  Files           267      267              
  Lines          8414     8414              
  Branches       1133     1133              
============================================
- Hits           3255     3224      -31     
- Misses         4742     4777      +35     
+ Partials        417      413       -4
Impacted Files Coverage Δ Complexity Δ
...a/csp/sentinel/slots/statistic/base/Striped64.java 26.04% <0%> (-23.96%) 5% <0%> (-2%)
...a/csp/sentinel/slots/statistic/base/LongAdder.java 17.02% <0%> (-14.9%) 4% <0%> (-4%)
...ava/com/alibaba/csp/sentinel/node/ClusterNode.java 95.45% <0%> (-4.55%) 7% <0%> (-1%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 775484b...3ebbf6f. Read the comment docs.

Copy link
Member

@sczyh30 sczyh30 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sczyh30 sczyh30 merged commit c7f3fd8 into alibaba:master Mar 8, 2019
@sczyh30
Copy link
Member

sczyh30 commented Mar 8, 2019

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/dashboard Issues or PRs about Sentinel Dashboard
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants