Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade apollo-client to 1.3.0 version & Add to unsubscribe config change event #562

Merged
merged 1 commit into from
Mar 11, 2019
Merged

Conversation

HaojunRen
Copy link
Contributor

@HaojunRen HaojunRen commented Mar 11, 2019

Add to unsubscribe config change event for new apollo-client version.

Fixes #561

Add to unsubscribe config change event
@CLAassistant
Copy link

CLAassistant commented Mar 11, 2019

CLA assistant check
All committers have signed the CLA.

@codecov-io
Copy link

Codecov Report

Merging #562 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #562      +/-   ##
============================================
- Coverage      38.8%   38.79%   -0.02%     
+ Complexity     1171     1170       -1     
============================================
  Files           267      267              
  Lines          8414     8414              
  Branches       1133     1133              
============================================
- Hits           3265     3264       -1     
  Misses         4726     4726              
- Partials        423      424       +1
Impacted Files Coverage Δ Complexity Δ
...l/cluster/server/connection/ConnectionManager.java 74% <0%> (-2%) 10% <0%> (-1%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c7f3fd8...9ca154c. Read the comment docs.

@sczyh30 sczyh30 added the to-review To review label Mar 11, 2019
@sczyh30
Copy link
Member

sczyh30 commented Mar 11, 2019

Hi, could you please sign the CLA here: https://cla-assistant.io/alibaba/Sentinel?pullRequest=562

Copy link
Member

@sczyh30 sczyh30 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sczyh30 sczyh30 merged commit 7367da6 into alibaba:master Mar 11, 2019
@sczyh30
Copy link
Member

sczyh30 commented Mar 11, 2019

Thanks for contributing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants