Dev lighting estimation #560

jmelou · 2019-01-03T13:56:41Z

Lighting estimation module:

define augmented normals and augmented lighting vector for spherical harmonic model;
lighting evaluation from albedo, picture and normals (linear least-square problem).

src/aliceVision/lightingEstimation/lightingEstimation.cpp

simogasp · 2019-01-03T17:07:14Z

src/aliceVision/lightingEstimation/lightingEstimation_test.cpp

+
+  Image<AugmentedNormal> agmNormalsSynt(normalsSynt.cast<AugmentedNormal>());
+
+  float noiseLevel = 0.01;


const float noiseLevel = 0.01f;

src/aliceVision/lightingEstimation/lightingEstimation_test.cpp

src/aliceVision/image/Image.hpp

simogasp · 2019-01-03T17:08:34Z

src/aliceVision/lightingEstimation/augmentedNormals.hpp

+namespace lightingEstimation {
+
+using Eigen::MatrixXf;
+using namespace aliceVision::image;


better not use using namespace in a header

src/aliceVision/lightingEstimation/augmentedNormals.hpp

jmelou and others added 5 commits December 5, 2018 18:34

[lightingEstimation] New module for lighting estimation

03f8608

[image] expose linear access to pixels

2af607f

[lightingEstimation] new AugmentedNormal struct and new unit test

d22c18c

[lightingEstimation] Add copyright header

d4cda57

[lightingEstimation] Add comments

4a8cedd

jmelou requested a review from fcastan January 3, 2019 13:56

simogasp requested changes Jan 3, 2019

View reviewed changes

jmelou added 3 commits January 4, 2019 10:39

[lightingEstimation] Constructor and destructor

ec9a579

[lightingEstimation] Remove using namespace from header

0a2c94d

[lightingEstimation] Add const

3a3d9e2

fabiencastan approved these changes Jan 5, 2019

View reviewed changes

simogasp approved these changes Jan 5, 2019

View reviewed changes

simogasp merged commit 31695c0 into develop Jan 5, 2019

simogasp deleted the dev_lighting_estimation branch January 5, 2019 16:52

fabiencastan added this to the 2019.1 milestone Jan 18, 2019

fabiencastan mentioned this pull request Sep 19, 2019

WIP [software] New software LightingEstimation #605

Closed

gregoire-dl mentioned this pull request May 15, 2020

[nodes] New node LightingEstimation alicevision/Meshroom#390

Merged

1 task

Provide feedback


		Image<AugmentedNormal> agmNormalsSynt(normalsSynt.cast<AugmentedNormal>());

		float noiseLevel = 0.01;