Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[nodes] New node LightingEstimation #390

Merged
merged 2 commits into from
Dec 15, 2020
Merged

[nodes] New node LightingEstimation #390

merged 2 commits into from
Dec 15, 2020

Conversation

gregoire-dl
Copy link
Member

@gregoire-dl gregoire-dl commented Feb 6, 2019 •
edited by fabiencastan
Loading

@gregoire-dl gregoire-dl added review scope:AliceVision concerning alicevision library labels Feb 6, 2019
@stale stale bot added the stale for issues that becomes stale (no solution) label Aug 25, 2019
@stale stale bot closed this Sep 1, 2019
@simogasp simogasp reopened this Sep 1, 2019
@stale stale bot removed the stale for issues that becomes stale (no solution) label Sep 1, 2019
@simogasp simogasp added the type:pr pull request issue label Sep 9, 2019
@natowi natowi mentioned this pull request Oct 11, 2019
Closed
@stale stale bot added the stale for issues that becomes stale (no solution) label Apr 11, 2020
@alicevision alicevision deleted a comment from stale bot Apr 11, 2020
@stale stale bot removed the stale for issues that becomes stale (no solution) label Apr 11, 2020
@fabiencastan fabiencastan added the do not close issue that should stay open (avoid automatically close because stale) label Apr 11, 2020
@fabiencastan fabiencastan marked this pull request as draft April 11, 2020 17:39
@Misterdudeman
Copy link

Any word on this PR getting merged? Seems to be a few hidden whitespace issues preventing it. Is there a better way of building this branch as it is configured with the old alicevision dockerfile and build method?

@alicevision alicevision deleted a comment from stale bot May 15, 2020
@alicevision alicevision deleted a comment from stale bot May 15, 2020
gregoire-dl and others added 2 commits May 25, 2020 22:44
@gregoire-dl @fabiencastan
[nodes] Add new node LightingEstimation
9aa059a
@yann-lty @fabiencastan
[ui] Viewer3D: introduce SphericalHarmonics shader + display mode
3ae9586 
Add experimental render mode to display model normals or shading based on spherical harmonics coefficients
@fabiencastan fabiencastan marked this pull request as ready for review May 26, 2020 14:44
@fabiencastan fabiencastan added this to the Meshroom 2020.1.0 milestone May 31, 2020
@fabiencastan fabiencastan merged commit cb9841d into develop Dec 15, 2020
@fabiencastan fabiencastan deleted the dev_lightingEstimation branch December 15, 2020 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabiencastan fabiencastan fabiencastan approved these changes

Assignees
No one assigned
Labels
do not close issue that should stay open (avoid automatically close because stale) review scope:AliceVision concerning alicevision library type:pr pull request issue
Projects
None yet
Milestone
Meshroom 2021.1.0
Development

Successfully merging this pull request may close these issues.
5 participants
@gregoire-dl @Misterdudeman @fabiencastan @simogasp @yann-lty