Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ui] Display nodes computed in another Meshroom instance as "Computed Externally" #1862

Merged
merged 2 commits into from
Jan 22, 2023
Merged

[ui] Display nodes computed in another Meshroom instance as "Computed Externally" #1862

merged 2 commits into from
Jan 22, 2023

Conversation

cbentejac
Copy link
Contributor

@cbentejac cbentejac commented Jan 5, 2023 •
edited by sbrood
Loading

Description

This PR contains a bugfix and a minor UI improvement:

  • Bugfix: a node used to be considered as computed externally if and only if its first chunk's execution mode was external. This is true in most cases but it does not cover the cases of nodes that are computed both locally and externally: if computations are started locally, interrupted and resumed externally, any chunk that completed its computations locally will have its execution mode set as such. When resuming the computations externally, the first chunk will still indicate that its execution mode is local, so the whole node will be treated as computed locally.
    A node is now considered as computed externally if at least one of its chunks' execution mode is external.
  • The "Computed Externally" icon used to be display on a node only when it was computing on the render farm. It is now also displayed when a node is computing in another instance of Meshroom.

Features list

  • Fix the method determining whether a node is submitted externally: a node is submitted externally if at least one of its chunks' execution mode is external
  • Display the "Computed Externally" icon on a node if it is being computed in another instance of Meshroom (or on a render farm)

@cbentejac
Display the "Computed Externally" icon whenever the node runs externally
45d3f20 
A node running externally used to mean it was running on a submitter.
This definition has been extended and a node is now considered to be
external if it is running on a submitter or running in another instance
of Meshroom. The "Computed Externally" is updated to reflect that
change.
@cbentejac
[core] Check all chunks' execution mode to determine if a node is ext…
9a956df 
…ernal

Prior to this commit, a node was considered external if its first chunk's
execution mode was EXTERN. In some cases, a node can be submitted
externally but have its first chunk's execution mode as LOCAL.

This can occur if computations are started locally then stopped and
resumed externally. If any chunk completed its computations locally,
then its execution mode will remain LOCAL, even if the node is submitted
externally later on.

A node is now considered external if at least one of its chunks'
execution mode is external.
@cbentejac cbentejac self-assigned this Jan 5, 2023
sbrood
sbrood reviewed Jan 10, 2023
View reviewed changes
Copy link
Contributor

@sbrood sbrood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested only for the case with 2 meshroom instances, it works. 👍

@fabiencastan fabiencastan merged commit d18e839 into develop Jan 22, 2023
@fabiencastan fabiencastan deleted the dev/externComputeIcon branch January 22, 2023 18:10
@fabiencastan fabiencastan added this to the Meshroom 2023.1.0 milestone Jan 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbrood sbrood sbrood left review comments

@fabiencastan fabiencastan fabiencastan approved these changes

@mugulmd mugulmd Awaiting requested review from mugulmd

Assignees

@cbentejac cbentejac

Labels
None yet
Projects
None yet
Milestone
Meshroom 2023.1.0
Development

Successfully merging this pull request may close these issues.
3 participants
@cbentejac @fabiencastan @sbrood