Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ui] Display nodes computed in another Meshroom instance as "Computed Externally" #1862

Merged
merged 2 commits into from
Jan 22, 2023
Merged

[ui] Display nodes computed in another Meshroom instance as "Computed Externally" #1862

merged 2 commits into from
Jan 22, 2023

Commits on Jan 5, 2023

  1. Display the "Computed Externally" icon whenever the node runs externally 

    A node running externally used to mean it was running on a submitter.
This definition has been extended and a node is now considered to be
external if it is running on a submitter or running in another instance
of Meshroom. The "Computed Externally" is updated to reflect that
change.
    @cbentejac
    cbentejac committed Jan 5, 2023
    Configuration menu
    Copy the full SHA
    45d3f20 View commit details
    Browse the repository at this point in the history

  2. [core] Check all chunks' execution mode to determine if a node is ext… 

    …ernal

Prior to this commit, a node was considered external if its first chunk's
execution mode was EXTERN. In some cases, a node can be submitted
externally but have its first chunk's execution mode as LOCAL.

This can occur if computations are started locally then stopped and
resumed externally. If any chunk completed its computations locally,
then its execution mode will remain LOCAL, even if the node is submitted
externally later on.

A node is now considered external if at least one of its chunks'
execution mode is external.
    @cbentejac
    cbentejac committed Jan 5, 2023
    Configuration menu
    Copy the full SHA
    9a956df View commit details
    Browse the repository at this point in the history