Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[pipelines] cameraTracking: change StructureFromMotion parameters #2055

Merged
merged 3 commits into from
Jun 15, 2023
Merged

[pipelines] cameraTracking: change StructureFromMotion parameters #2055

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9194b13
[nodes] SfM: extend nbFirstUnstableCamera range to 0
mugulmd Jun 15, 2023
e6d58de
[nodes] SfM: extend maxImagesPerGroup range to 0
mugulmd Jun 15, 2023
4ee5cd6
[pipelines] cameraTracking: change StructureFromMotion parameters
mugulmd Jun 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions meshroom/nodes/aliceVision/StructureFromMotion.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -176,7 +176,7 @@ class StructureFromMotion(desc.AVCommandLineNode):
'This leads to more stable results while computations are not too expensive, as there is little data.\n'
'Past this number, the bundle adjustment will only be performed once for N added cameras.',
value=30,
range=(1, 100, 1),
range=(0, 100, 1),
uid=[0],
advanced=True
),
Expand All @@ -186,7 +186,7 @@ class StructureFromMotion(desc.AVCommandLineNode):
description='Maximum number of cameras that can be added before the bundle adjustment has to be performed again.\n'
'This prevents adding too much data at once without performing the bundle adjustment.',
value=30,
range=(1, 100, 1),
range=(0, 100, 1),
uid=[0],
advanced=True
),
Expand Down
39 changes: 21 additions & 18 deletions meshroom/pipelines/cameraTracking.mg
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,30 +5,30 @@
"fileVersion": "1.1",
"template": true,
"nodesVersions": {
"ImageMatching": "2.0",
"ConvertSfMFormat": "2.0",
"ExportDistortion": "1.0",
"SfMTransfer": "2.1",
"KeyframeSelection": "4.1",
"FeatureExtraction": "1.2",
"CameraInit": "9.0",
"DistortionCalibration": "3.0",
"Meshing": "7.0",
"MeshDecimate": "1.0",
"DepthMap": "4.0",
"MeshFiltering": "3.0",
"SfMTriangulation": "1.0",
"ExportDistortion": "1.0",
"DepthMapFilter": "3.0",
"DistortionCalibration": "3.0",
"PrepareDenseScene": "3.0",
"KeyframeSelection": "4.1",
"Publish": "1.3",
"Texturing": "6.0",
"StructureFromMotion": "3.1",
"CheckerboardDetection": "1.0",
"ImageMatchingMultiSfM": "1.0",
"CameraInit": "9.0",
"ApplyCalibration": "1.0",
"Texturing": "6.0",
"PrepareDenseScene": "3.0",
"Publish": "1.3",
"ExportAnimatedCamera": "2.0",
"Meshing": "7.0",
"MeshDecimate": "1.0",
"DepthMapFilter": "3.0",
"ScenePreview": "1.0",
"ConvertSfMFormat": "2.0",
"MeshFiltering": "3.0",
"FeatureMatching": "2.0",
"ImageMatching": "2.0",
"SfMTransfer": "2.1"
"ImageMatchingMultiSfM": "1.0",
"CheckerboardDetection": "1.0",
"FeatureMatching": "2.0"
}
},
"graph": {
Expand Down Expand Up @@ -330,6 +330,9 @@
"{FeatureMatching_2.output}"
],
"describerTypes": "{FeatureMatching_3.describerTypes}",
"nbFirstUnstableCameras": 0,
"maxImagesPerGroup": 0,
"bundleAdjustmentMaxOutliers": -1,
"minInputTrackLength": 5,
"minNumberOfObservationsForTriangulation": 3,
"minAngleForTriangulation": 1.0,
Expand Down Expand Up @@ -416,4 +419,4 @@
}
}
}
}
}