[pipelines] cameraTracking: change StructureFromMotion parameters #2055

mugulmd · 2023-06-14T10:23:08Z

Description

Change BA related parameters in the central StructureFromMotion node in the cameraTracking pipeline.

This new parameter set provides results faster than the current one (2x to 3x) without loss of quality on the tested datasets.

fabiencastan · 2023-06-15T07:45:08Z

            "nbFirstUnstableCameras": 0,
            "maxImagesPerGroup": 0,
            "bundleAdjustmentMaxOutliers": -1,

mugulmd · 2023-06-15T07:49:10Z

            "nbFirstUnstableCameras": 0,
            "maxImagesPerGroup": 0,
            "bundleAdjustmentMaxOutliers": -1,

I think the range for nbFirstUnstableCameras in the UI starts at 1

meshroom/pipelines/cameraTracking.mg

mugulmd added this to the Meshroom 2023.2.0 milestone Jun 14, 2023

mugulmd requested a review from fabiencastan June 14, 2023 10:23

mugulmd self-assigned this Jun 14, 2023

[nodes] SfM: extend nbFirstUnstableCamera range to 0

9194b13

mugulmd force-pushed the mug/trackingSfMParams branch from a91ded4 to 6f3c3ac Compare June 15, 2023 09:30

fabiencastan reviewed Jun 15, 2023

View reviewed changes

meshroom/pipelines/cameraTracking.mg Outdated Show resolved Hide resolved

mugulmd added 2 commits June 15, 2023 12:02

[nodes] SfM: extend maxImagesPerGroup range to 0

e6d58de

[pipelines] cameraTracking: change StructureFromMotion parameters

4ee5cd6

mugulmd force-pushed the mug/trackingSfMParams branch from 6f3c3ac to 4ee5cd6 Compare June 15, 2023 10:03

fabiencastan approved these changes Jun 15, 2023

View reviewed changes

fabiencastan merged commit 6ac9948 into develop Jun 15, 2023

fabiencastan deleted the mug/trackingSfMParams branch June 15, 2023 13:02