[nodes] PanoramaPostProcessing: Add attributes to change the outputs' names #2193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cbentejac
requested review from
fabiencastan,
mugulmd and
servantftechnicolor
cbentejac
force-pushed
the
dev/panoPostProcessOutputs
branch
from
0b87f68
to
12f64b8
Compare
servantftechnicolor
approved these changes
Sep 19, 2023
cbentejac
added
the
invalidate:node
… names Add input String parameters to determine the name of the generated outputs. These attributes include: - the name of the generated output panorama - the name of the generated output panorama preview The base folder for these outputs remains the node's cache, only the name of the outputs themselves can be updated. The output attribute about the downscaled levels of the panorama is also modified with the new name of the pyramid levels, which is a concatenation of the generated panorama's name and the size of the current level.
cbentejac
force-pushed
the
dev/panoPostProcessOutputs
branch
from
12f64b8
to
ceba9c5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds two new input String parameters to the
PanoramaPostProcessingnode to determine the name of the generated outputs. These attributes include:These two attributes are not added to the command line, as their only purpose is to be used to set the names of the outputs at will. The base folder for these outputs remains the node's cache, only the name of the outputs themselves can be updated.
The
downscaledPanoramaLevelsoutput attribute is also updated following alicevision/AliceVision#1542, since the name of the downscaled levels is now a concatenation of the generated panorama's name, "level" and the size of the level.As a consequence, the version of the
PanoramaPostProcessingnode is upgraded, and the templates using it are updated accordingly.