Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[nodes] PanoramaPostProcessing: Add attributes to change the outputs' names #2193

Merged
merged 2 commits into from
Sep 19, 2023
Merged

[nodes] PanoramaPostProcessing: Add attributes to change the outputs' names #2193

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3aad1cc
[nodes] PanoramaPostProcessing: Add attributes to change the outputs'…
cbentejac Sep 19, 2023
ceba9c5
[pipelines] Panorama: Update the `PanoramaPostProcessing` node's version
cbentejac Sep 19, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 21 additions & 3 deletions meshroom/nodes/aliceVision/PanoramaPostProcessing.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,6 +83,24 @@ class PanoramaPostProcessing(desc.CommandLineNode):
uid=[0],
enabled=lambda node: node.compressionMethod.value in ["dwaa", "dwab", "zip", "zips"]
),
desc.StringParam(
name="panoramaName",
label="Output Panorama Name",
description="Name of the output panorama.",
value="panorama.exr",
uid=[],
group=None,
advanced=True
),
desc.StringParam(
name="previewName",
label="Panorama Preview Name",
description="Name of the preview of the output panorama.",
value="panoramaPreview.jpg",
uid=[],
group=None,
advanced=True,
),
desc.ChoiceParam(
name="verboseLevel",
label="Verbose Level",
Expand All @@ -100,22 +118,22 @@ class PanoramaPostProcessing(desc.CommandLineNode):
label="Output Panorama",
description="Generated panorama in EXR format.",
semantic="image",
value=desc.Node.internalFolder + "panorama.exr",
value=lambda attr: desc.Node.internalFolder + attr.node.panoramaName.value,
uid=[],
),
desc.File(
name="outputPanoramaPreview",
label="Output Panorama Preview",
description="Preview of the generated panorama in JPG format.",
semantic="image",
value=desc.Node.internalFolder + "panoramaPreview.jpg",
value=lambda attr: desc.Node.internalFolder + attr.node.previewName.value,
uid=[],
),
desc.File(
name="downscaledPanoramaLevels",
label="Downscaled Panorama Levels",
description="Downscaled versions of the generated panorama.",
value=desc.Node.internalFolder + "level_*.exr",
value=lambda attr: desc.Node.internalFolder + os.path.splitext(attr.node.panoramaName.value)[0] + "_level_*.exr",
uid=[],
group='',
),
Expand Down
2 changes: 1 addition & 1 deletion meshroom/pipelines/panoramaFisheyeHdr.mg
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
"PanoramaPrepareImages": "1.1",
"PanoramaInit": "2.0",
"Publish": "1.3",
"PanoramaPostProcessing": "2.0",
"PanoramaPostProcessing": "2.1",
"FeatureMatching": "2.0",
"LdrToHdrSampling": "4.0",
"PanoramaWarping": "1.1",
Expand Down
2 changes: 1 addition & 1 deletion meshroom/pipelines/panoramaHdr.mg
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
"PanoramaPrepareImages": "1.1",
"PanoramaInit": "2.0",
"Publish": "1.3",
"PanoramaPostProcessing": "2.0",
"PanoramaPostProcessing": "2.1",
"FeatureMatching": "2.0",
"LdrToHdrSampling": "4.0",
"PanoramaWarping": "1.1",
Expand Down