[Viewer3D] Connect any change of the selected view ID to the SfmDataLoader #2237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mh0g
approved these changes
Nov 15, 2023
cbentejac
force-pushed
the
dev/highlightSelectedCamera
branch
from
9dedc43
to
e4d0243
Compare
fabiencastan
approved these changes
Nov 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR connects the
selectedViewIdproperty from theReconstructionobject to theselectedViewIdproperty of theSfmDataLoaderobject: any change of the currently selected view ID, either by selecting another image in the Image Gallery or by clicking on a camera in the 3D Viewer, will be propagated to QtAliceVision.This relates to alicevision/QtAliceVision#52.