[qmlSfmData] Upscale the currently selected camera #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cbentejac
force-pushed
the
dev/highlightSelectedCamera
branch
3 times, most recently
from
62d5ee1
to
815fb9c
Compare
mh0g
approved these changes
Nov 15, 2023
Compared to the non-selected cameras, apply a bigger scale factor on the camera that corresponds to the currently selected view ID.
A camera's colors are updated to blue when it becomes the active camera, and set back to white when the current view ID changes.
cbentejac
force-pushed
the
dev/highlightSelectedCamera
branch
from
815fb9c
to
e9e3d8d
Compare
fabiencastan
approved these changes
Nov 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a getter for the
viewIdmember of theCameraLocatorEntityobject and uses it to determine the camera that is currently selected.That specific camera is upscaled with a factor of 1.5 in order to better stand out and the color of its gizmo is set to blue. Prior to this PR, the currently selected camera was only highlighted by having its object picker's color set to blue. For photogrammetry use cases, this was enough to identify it easily as the cameras are generally spread around. For camera tracking use cases, this was more difficult as the cameras are very closely following each other.
As soon as the camera is not selected anymore, it is rescaled normally and the gizmo's color is set to white again. The upscale is also correctly applied when the global scale for all the cameras is updated.
The information about the currently selected camera is obtained from the QML side through alicevision/Meshroom#2237.