-
Notifications
You must be signed in to change notification settings - Fork 2.3k
Conversation
…nto roll-backbone
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one question: Why repeat_interleave()
?
Let me know when this is ready to be looked at again? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. I assume there is a corresponding change in the models repo somewhere that changes how your reader operates, correct?
Yup! I already changed my nlvr2 reader to work with these changes; I'm training that model again now and then I'll be able to send out that PR as well. |
Adding support for inputs to the backbone with more than 3 dimensions
Changes proposed in this pull request:
Before submitting
section of the
CONTRIBUTING
docs.Writing docstrings section of the
CONTRIBUTING
docs.After submitting
codecov/patch
reports high test coverage (at least 90%).You can find this under the "Actions" tab of the pull request once the other checks have finished.