Skip to content
This repository has been archived by the owner on Jul 29, 2019. It is now read-only.

Fix hiding edge tooltip when a node is hovered #4026

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

Gelio
Copy link

@Gelio Gelio commented Jul 5, 2018

When supplying an edge tooltip (title) without providing a node tooltip (title), the edge's tooltip will be displayed even though the node is hovered and the tooltip is in the background.

screenshot from 2018-07-05 16-37-43

This PR fixes that behavior.

@micahstubbs
Copy link

@yotamberk could you tag this one as network when you have a moment?

@micahstubbs
Copy link

@Gelio thanks for the sending this PR with the fix! appreciate the screenshot as well 😄

Curious, could you provide a new example that we can use to verify the fix, or point us to an existing example that shows the bug behavior (and would also show the fix)?

https://github.com/almende/vis/tree/master/examples/network

said another way, could you provide steps to test this PR?

@Gelio
Copy link
Author

Gelio commented Sep 4, 2018

@micahstubbs Sure, no problem.

Take a look at data/scalingNodesEdges.html.

  1. Hover over an edge until the tooltip appears
  2. Move the mouse towards a node (following the edge)
  3. Move the mouse into the node (following the edge)

The tooltip does not disappear, even though the edge is technically not visible now since the node is on top of it.

@micahstubbs
Copy link

micahstubbs commented Sep 4, 2018

@Gelio thanks for the steps to test! the fix looks good to me ✅

http://127.0.0.1:51702/examples/network/data/scalingNodesEdgesLabels.html

before

vis-pr-4026-before

after

vis-pr-4026-after

@Gelio
Copy link
Author

Gelio commented Sep 4, 2018

@micahstubbs Awesome 👍 Thank you for verifying it and providing the gifs 😄

@micahstubbs
Copy link

@Gelio of course! I've accepted this improvement over on our community fork https://github.com/visjs-community/visjs-network

visjs-community/visjs-network#26

hopefully the maintainers here will see the review and accept the PR as well 😄

@Gelio
Copy link
Author

Gelio commented Sep 4, 2018

@micahstubbs Great, thanks 😃

@mojoaxel
Copy link
Member

💌 Thanks @Gelio for your contribution!
This pull-request has been merge into visjs/vis-network#21

@mojoaxel mojoaxel added Network visjs APPLIED this PR was merged into a repo of the visjs family labels Jul 27, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Network visjs APPLIED this PR was merged into a repo of the visjs family
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants