Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vis#4026: remove edge tooltip when hovering a node #21

Merged
merged 1 commit into from
Jul 27, 2019

Conversation

mojoaxel
Copy link
Member

This is an original contribution from @Gelioalmende/vis#4026
This was also copies to visjs-netwoek: 
visjs-community/visjs-network#26

partially fixes #7


When supplying an edge tooltip (title) without providing a node tooltip (title), the edge's tooltip will be displayed even though the node is hovered and the tooltip is in the background.

screenshot from 2018-07-05 16-37-43

This PR fixes that behavior.


How to reproduce:
Take a look at https://almende.github.io/vis/examples/network/data/scalingNodesEdgesLabels.html

  • Hover over an edge until the tooltip appears
  • Move the mouse towards a node (following the edge)
  • Move the mouse into the node (following the edge)

The tooltip does not disappear, even though the edge is technically not visible now since the node is on top of it.


before

vis-pr-4026-before

after

vis-pr-4026-after

@mojoaxel mojoaxel changed the title Add hiding edge tooltip when a node is hovered vis#4026: remove edge tooltip when hovering a node Jul 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants