Handle incorrectly UTF-8 encoded query and cookie url #3815
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
unoduetre
force-pushed
the
2938-silently-handle-invalid-byte-sequence-in-utf-8-errors-l
branch
from
37135b7
to
dae6678
Compare
Use a different exception when this situation is detected: * Sanitiser::Strategy::SanitisingError This error is not sent to Sentry. See: alphagov/govuk_app_config#402
unoduetre
force-pushed
the
2938-silently-handle-invalid-byte-sequence-in-utf-8-errors-l
branch
from
91c6083
to
abc1749
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use a different exception when this situation is detected:
See: Add Sanitiser::Strategy::SanitisingError to the list of excluded errors govuk_app_config#402
Follow these steps if you are doing a Rails upgrade.
What
Stop sentry alerting on the “invalid byte sequence in UTF-8 errors”.
As discussed with @hannako, we will use a a solution based on an external gem called
rack-utf8_sanitizerinstead of developing our own gem. This solution will then be used in all our apps by copy-pasting the configuration of this gem.Why
When security scanning of our site takes place we are inundated with these errors in our slack channel. These errors are not serving any purpose since there is no issue to be solved. Therefore we should remove them to keep all our alerts actionable.
We often get exceptions in Sentry coming from a security checking bot that attempts some attacks by using strings with special characters. All of those "attacks" fail, but they produce exceptions which we would like to ignore, so they do not clutter Sentry. On the other hand we don’t want to ignore exceptions of the same class coming from other sources.
Trello card