Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Sanitiser::Strategy::SanitisingError to the list of excluded errors #402

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

unoduetre
Copy link
Contributor

⚠️ Make sure you release a new version of this gem after merging your changes. ⚠️

Refer to the existing docs if you are making changes to the supported Ruby versions.

What

Do not send Sanitiser::Strategy::SanitisingError to Sentry. This error should still be raised in all environments.

This error is raised in some apps when an incorrect (wrong UTF-8 encoding) character is encountered in a query string or in a cookie.

Why

Trello card

@unoduetre unoduetre force-pushed the 2938-silently-handle-invalid-byte-sequence-in-utf-8-errors-l branch from c45e890 to 17efe1f Compare October 17, 2024 14:04
unoduetre added a commit that referenced this pull request Oct 17, 2024
* Add Sanitiser::Strategy::SanitisingError to excluded exceptions list ([#402](#402))
unoduetre added a commit to alphagov/government-frontend that referenced this pull request Oct 17, 2024
Use a different exception when this situation is detected:
* Sanitiser::Strategy::SanitisingError
This error is not sent to Sentry.
See: alphagov/govuk_app_config#402
* Add Sanitiser::Strategy::SanitisingError to excluded exceptions list ([#402](#402))
@unoduetre unoduetre force-pushed the 2938-silently-handle-invalid-byte-sequence-in-utf-8-errors-l branch from 8807acd to 7b8d453 Compare October 23, 2024 13:35
unoduetre added a commit to alphagov/government-frontend that referenced this pull request Oct 23, 2024
Use a different exception when this situation is detected:
* Sanitiser::Strategy::SanitisingError
This error is not sent to Sentry.
See: alphagov/govuk_app_config#402
@unoduetre unoduetre marked this pull request as ready for review October 23, 2024 13:43
unoduetre added a commit to alphagov/static that referenced this pull request Oct 25, 2024
Use a different exception when this situation is detected:
* Sanitiser::Strategy::SanitisingError
This error is not sent to Sentry.
See: alphagov/govuk_app_config#402
unoduetre added a commit to alphagov/collections that referenced this pull request Oct 25, 2024
Use a different exception when this situation is detected:
* Sanitiser::Strategy::SanitisingError
This error is not sent to Sentry.
See: alphagov/govuk_app_config#402
unoduetre added a commit to alphagov/frontend that referenced this pull request Oct 25, 2024
Use a different exception when this situation is detected:
* Sanitiser::Strategy::SanitisingError
This error is not sent to Sentry.
See: alphagov/govuk_app_config#402
unoduetre added a commit to alphagov/frontend that referenced this pull request Oct 25, 2024
Use a different exception when this situation is detected:
* Sanitiser::Strategy::SanitisingError
This error is not sent to Sentry.
See: alphagov/govuk_app_config#402
unoduetre added a commit to alphagov/frontend that referenced this pull request Oct 25, 2024
Use a different exception when this situation is detected:
* Sanitiser::Strategy::SanitisingError
This error is not sent to Sentry.
See: alphagov/govuk_app_config#402
unoduetre added a commit to alphagov/collections that referenced this pull request Oct 25, 2024
Use a different exception when this situation is detected:
* Sanitiser::Strategy::SanitisingError
This error is not sent to Sentry.
See: alphagov/govuk_app_config#402
unoduetre added a commit to alphagov/collections that referenced this pull request Oct 25, 2024
Use a different exception when this situation is detected:
* Sanitiser::Strategy::SanitisingError
This error is not sent to Sentry.
See: alphagov/govuk_app_config#402
unoduetre added a commit to alphagov/static that referenced this pull request Oct 25, 2024
Use a different exception when this situation is detected:
* Sanitiser::Strategy::SanitisingError
This error is not sent to Sentry.
See: alphagov/govuk_app_config#402
unoduetre added a commit to alphagov/frontend that referenced this pull request Oct 25, 2024
Use a different exception when this situation is detected:
* Sanitiser::Strategy::SanitisingError
This error is not sent to Sentry.
See: alphagov/govuk_app_config#402
unoduetre added a commit to alphagov/frontend that referenced this pull request Oct 25, 2024
Use a different exception when this situation is detected:
* Sanitiser::Strategy::SanitisingError
This error is not sent to Sentry.
See: alphagov/govuk_app_config#402
unoduetre added a commit to alphagov/static that referenced this pull request Oct 25, 2024
Use a different exception when this situation is detected:
* Sanitiser::Strategy::SanitisingError
This error is not sent to Sentry.
See: alphagov/govuk_app_config#402
unoduetre added a commit to alphagov/collections that referenced this pull request Oct 25, 2024
Use a different exception when this situation is detected:
* Sanitiser::Strategy::SanitisingError
This error is not sent to Sentry.
See: alphagov/govuk_app_config#402
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants