Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new page describing our browser support strategy #356

Merged
merged 2 commits into from
Oct 26, 2023

Conversation

romaricpascal
Copy link
Member

@romaricpascal romaricpascal commented Oct 24, 2023

Adds the content of the draft of our summary of our browser support strategy (internal link) to the docs.

Couldn't remember if/where we said we'd put it in the menu, so just appended it to the list. Please feel free to update the PR and put it at another level.

Part of #340 (the issue needs to wait for the full guidance to have been merged on the govuk-frontend repo before being closed).

@netlify
Copy link

netlify bot commented Oct 24, 2023

Deploy Preview for govuk-frontend-docs-preview ready!

Name Link
🔨 Latest commit e6b9ad5
🔍 Latest deploy log https://app.netlify.com/sites/govuk-frontend-docs-preview/deploys/653a6a03a7eee1000989f987
😎 Deploy Preview https://deploy-preview-356--govuk-frontend-docs-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@romaricpascal romaricpascal force-pushed the browser-support branch 3 times, most recently from 0951659 to 629791c Compare October 24, 2023 16:50
@romaricpascal romaricpascal changed the base branch from main to release/5.0 October 24, 2023 16:50
@romaricpascal romaricpascal marked this pull request as ready for review October 24, 2023 16:57

To make sure the public can successfully access and use government services, regardless of the browser they're using, the Design System team has divided browsers into 4 grades. Each grade shows the level of support we will provide.

You can see more information about [how we provide support for different browsers](https://github.com/alphagov/govuk-frontend/blob/main/docs/contributing/browser-support.md) in our GitHub documentation.
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

note The link needs a PR adding the full version of the docs to the govuk-frontend site to have been merged.

@claireashworth
Copy link
Contributor

This page needs to go above the 'Use Nunjucks' page.

@romaricpascal
Copy link
Member Author

@claireashworth The page has been moved to the right level in the menu.

Copy link
Contributor

@domoscargin domoscargin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!


To make sure the public can successfully access and use government services, regardless of the browser they're using, the Design System team has divided browsers into 4 grades. Each grade shows the level of support we will provide.

You can see more informatgion about [how we provide support for different browsers](https://github.com/alphagov/govuk-frontend/blob/main/docs/contributing/browser-support.md) in our GitHub documentation.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
You can see more informatgion about [how we provide support for different browsers](https://github.com/alphagov/govuk-frontend/blob/main/docs/contributing/browser-support.md) in our GitHub documentation.
You can see more information about [how we provide support for different browsers](https://github.com/alphagov/govuk-frontend/blob/main/docs/contributing/browser-support.md) in our GitHub documentation.

@romaricpascal romaricpascal merged commit 0afde0e into release/5.0 Oct 26, 2023
5 checks passed
@romaricpascal romaricpascal deleted the browser-support branch October 26, 2023 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants