-
Notifications
You must be signed in to change notification settings - Fork 326
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add content of the draft of our browser support strategy to our docs #4381
Conversation
📋 StatsFile sizes
Modules
View stats and visualisations on the review app Action run for 1f8047a |
docs/contributing/browser-support.md
Outdated
@@ -0,0 +1,215 @@ | |||
# How we provide support for different browsers | |||
|
|||
Users can access government services through a wide range of new to older browsers. Our components provide a baseline experience through HTML and CSS, allowing all users to complete their tasks even [if JavaScript is not working](https://www.kryogenix.org/code/browser/everyonehasjs.html). Some components have JavaScript enhancements which add extra features or fix accessibility issues. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Users can access government services through a wide range of new to older browsers. Our components provide a baseline experience through HTML and CSS, allowing all users to complete their tasks even [if JavaScript is not working](https://www.kryogenix.org/code/browser/everyonehasjs.html). Some components have JavaScript enhancements which add extra features or fix accessibility issues. | |
Users can access government services through a wide range of new to older browsers. Our components provide a baseline experience through HTML and CSS, allowing all users to complete their tasks even if JavaScript is not working. Some components have JavaScript enhancements which add extra features or fix accessibility issues. |
docs/contributing/browser-support.md
Outdated
<table> | ||
<tbody> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The table looks great on wider screens, but it's super squished on mobiles 😣
Think we can find an alternative?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We disable Prettier embeddedLanguageFormatting
but probably stick to 2-spaces?
<table> | |
<tbody> | |
<table> | |
<tbody> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can move everything out into bullet points for each grade?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggest we leave the table in for this pre-release, then think about another solution for the next, or as @romaricpascal has pointed out - before any user sessions.
d085d4a
to
bb8183d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Co-authored-by: Claire Ashworth <[email protected]>
ee5305a
to
1f8047a
Compare
Adds the content of the draft of the full version of our browser support strategy to the docs (internal link).
The location is based on this discussion on Slack (internal link).
I've brought the range of Safari versions from the summary.
The table has to be in HTML due to some complex content in the cells. I've opted for semantics when marking up the list of browsers in there, which adds bullets at the start of the list items. If we prefer the formatting from the document, we can go with paragraphs and
<br>
:Part of alphagov/govuk-frontend-docs#340 (the issue needs to wait for the guidance summary to have been merged on the
govuk-frontend-docs
repo before being closed).