Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add content of the draft of our browser support strategy to our docs #4381

Merged
merged 2 commits into from
Oct 26, 2023

Conversation

romaricpascal
Copy link
Member

@romaricpascal romaricpascal commented Oct 24, 2023

WIP The README still needs updating following this discussion on Slack (internal link) to link to the docs

Adds the content of the draft of the full version of our browser support strategy to the docs (internal link).

The location is based on this discussion on Slack (internal link).

I've brought the range of Safari versions from the summary.

The table has to be in HTML due to some complex content in the cells. I've opted for semantics when marking up the list of browsers in there, which adds bullets at the start of the list items. If we prefer the formatting from the document, we can go with paragraphs and <br>:

<p>
Chrome 61+<br>
Edge 16-18<br>
Edge 79+<br>
Safari 11+ (mac)<br>
Firefox 60+<br>
Opera 48+
</p>
<p>
Safari 10.3+ (iOS)<br>
Samsung Internet 8.2+
</p>

Part of alphagov/govuk-frontend-docs#340 (the issue needs to wait for the guidance summary to have been merged on the govuk-frontend-docs repo before being closed).

@github-actions
Copy link

github-actions bot commented Oct 24, 2023

📋 Stats

File sizes

File Size
dist/govuk-frontend-5.0.0-internal.0.min.css 114.01 KiB
dist/govuk-frontend-5.0.0-internal.0.min.js 37.86 KiB
packages/govuk-frontend/dist/govuk/all.bundle.js 76.77 KiB
packages/govuk-frontend/dist/govuk/all.bundle.mjs 72.08 KiB
packages/govuk-frontend/dist/govuk/all.mjs 3.8 KiB
packages/govuk-frontend/dist/govuk/govuk-frontend-component.mjs 359 B
packages/govuk-frontend/dist/govuk/govuk-frontend.min.css 113.99 KiB
packages/govuk-frontend/dist/govuk/govuk-frontend.min.js 37.84 KiB
packages/govuk-frontend/dist/govuk/i18n.mjs 5.3 KiB

Modules

File Size
all.mjs 68.41 KiB
components/accordion/accordion.mjs 21.05 KiB
components/button/button.mjs 4.18 KiB
components/character-count/character-count.mjs 20.49 KiB
components/checkboxes/checkboxes.mjs 5.31 KiB
components/error-summary/error-summary.mjs 5.49 KiB
components/exit-this-page/exit-this-page.mjs 15.49 KiB
components/header/header.mjs 3.39 KiB
components/notification-banner/notification-banner.mjs 4.02 KiB
components/radios/radios.mjs 4.31 KiB
components/skip-link/skip-link.mjs 3.3 KiB
components/tabs/tabs.mjs 9.07 KiB

View stats and visualisations on the review app


Action run for 1f8047a

@@ -0,0 +1,215 @@
# How we provide support for different browsers

Users can access government services through a wide range of new to older browsers. Our components provide a baseline experience through HTML and CSS, allowing all users to complete their tasks even [if JavaScript is not working](https://www.kryogenix.org/code/browser/everyonehasjs.html). Some components have JavaScript enhancements which add extra features or fix accessibility issues.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Users can access government services through a wide range of new to older browsers. Our components provide a baseline experience through HTML and CSS, allowing all users to complete their tasks even [if JavaScript is not working](https://www.kryogenix.org/code/browser/everyonehasjs.html). Some components have JavaScript enhancements which add extra features or fix accessibility issues.
Users can access government services through a wide range of new to older browsers. Our components provide a baseline experience through HTML and CSS, allowing all users to complete their tasks even if JavaScript is not working. Some components have JavaScript enhancements which add extra features or fix accessibility issues.

Comment on lines 70 to 71
<table>
<tbody>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The table looks great on wider screens, but it's super squished on mobiles 😣

Think we can find an alternative?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We disable Prettier embeddedLanguageFormatting but probably stick to 2-spaces?

Suggested change
<table>
<tbody>
<table>
<tbody>

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can move everything out into bullet points for each grade?

Copy link
Contributor

@domoscargin domoscargin Oct 26, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggest we leave the table in for this pre-release, then think about another solution for the next, or as @romaricpascal has pointed out - before any user sessions.

@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-pr-4381 October 26, 2023 12:54 Inactive
@romaricpascal romaricpascal marked this pull request as ready for review October 26, 2023 14:02
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-pr-4381 October 26, 2023 14:10 Inactive
Copy link
Contributor

@domoscargin domoscargin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-pr-4381 October 26, 2023 14:17 Inactive
@romaricpascal romaricpascal merged commit 4511dde into main Oct 26, 2023
44 checks passed
@romaricpascal romaricpascal deleted the browser-support branch October 26, 2023 14:31
@romaricpascal romaricpascal linked an issue Oct 26, 2023 that may be closed by this pull request
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update README to reflect changes to browser support
5 participants