Skip to content
This repository has been archived by the owner on Oct 4, 2024. It is now read-only.

Commit

Permalink
Make Pact test pre-merge checks not block merge.
Browse files Browse the repository at this point in the history
The manual says we don't block merge on failed pact tests, but the
config lists them as required for merge.

I'm sure there's some way we can do this better, but for now let's just
make the config match the docs so that people don't get snookered when
making API changes like in
alphagov/publishing-api#2683.
  • Loading branch information
sengi committed Mar 27, 2024
1 parent 5e44104 commit f6b54e2
Showing 1 changed file with 0 additions and 11 deletions.
11 changes: 0 additions & 11 deletions github/repo_overrides.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@ alphagov/account-api:
- Test Ruby
- Lint Ruby / Run RuboCop
- Security Analysis / Run Brakeman
- Run Pact tests / Verify pact tests

alphagov/asset-manager:
# required for continuous deployment
Expand All @@ -17,7 +16,6 @@ alphagov/asset-manager:
additional_contexts:
- Test Ruby
- Lint Ruby / Run RuboCop
- Run Pact tests / Verify pact tests
- Security Analysis / Run Brakeman

alphagov/authenticating-proxy:
Expand Down Expand Up @@ -50,7 +48,6 @@ alphagov/collections:
- Lint JavaScript / Run Standardx
- Lint SCSS / Run Stylelint
- Security Analysis / Run Brakeman
- Run Pact tests / Verify pact tests
- Test JavaScript / Run Jasmine
- Test Ruby / Run RSpec

Expand Down Expand Up @@ -95,7 +92,6 @@ alphagov/content-store:
required_status_checks:
additional_contexts:
- Lint Ruby / Run RuboCop
- Run Pact tests / Verify pact tests
- Security Analysis / Run Brakeman
- Test Ruby / Run RSpec

Expand Down Expand Up @@ -124,7 +120,6 @@ alphagov/email-alert-api:
required_status_checks:
additional_contexts:
- Test Ruby
- Run Pact tests / Verify pact tests
- Lint Ruby / Run RuboCop
- Security Analysis / Run Brakeman

Expand Down Expand Up @@ -171,7 +166,6 @@ alphagov/frontend:
additional_contexts:
- Lint Ruby / Run RuboCop
- Lint JavaScript / Run Standardx
- Run Pact tests / Verify pact tests
- Lint SCSS / Run Stylelint
- Security Analysis / Run Brakeman
- Test JavaScript / Run Jasmine
Expand Down Expand Up @@ -211,7 +205,6 @@ alphagov/imminence:
- Integration tests
- Test Ruby
- Lint Ruby / Run RuboCop
- Run Pact tests / Verify pact tests
- Security Analysis / Run Brakeman

alphagov/link-checker-api:
Expand All @@ -223,7 +216,6 @@ alphagov/link-checker-api:
- Test Ruby
- Security Analysis / Run Brakeman
- Lint Ruby / Run RuboCop
- Run Pact tests / Verify pact tests

alphagov/local-links-manager:
# required for continuous deployment
Expand All @@ -246,7 +238,6 @@ alphagov/locations-api:
- Test Ruby
- Security Analysis / Run Brakeman
- Lint Ruby / Run RuboCop
- Run Pact tests / Verify pact tests

alphagov/release:
# required for continuous deployment
Expand Down Expand Up @@ -343,9 +334,7 @@ alphagov/publishing-api:
- Check content schemas are built
- Test Ruby
- Lint Ruby / Run RuboCop
- Run GDS API Adapter Pact tests / Verify pact tests
- Security Analysis / Run Brakeman
- Run Content Store Pact tests / Verify pact tests

alphagov/finder-frontend:
# required for continuous deployment
Expand Down

0 comments on commit f6b54e2

Please sign in to comment.