Remove topic from publishing-api specs #2683
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
unoduetre
changed the title
hannako
approved these changes
Mar 26, 2024
There was a problem hiding this comment.
This looks good to me, thank you @unoduetre
Once a dev from publishing-platform approves, how will we roll this out?
If your question is about the Pact tests, there is a document I will follow: https://docs.publishing.service.gov.uk/manual/pact-testing.html#changing-existing-pact-tests |
callumknights
approved these changes
Mar 26, 2024
unoduetre
deleted the
2417-remove-specialist-topic-code-from-publishing-api-l-6
branch
sengi
added a commit
to alphagov/govuk-saas-config
that referenced
this pull request
Mar 27, 2024
The manual says we don't block merge on failed pact tests, but the config lists them as required for merge. I'm sure there's some way we can do this better, but for now let's just make the config match the docs so that people don't get snookered when making API changes like in alphagov/publishing-api#2683.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This application is owned by the publishing platform team. Please let us know in #govuk-publishing-platform when you raise any PRs.
Follow these steps if you are doing a Rails upgrade.
What
Remove specialist topics from publishing-api tests.
Why
Retiring specialist topics.
Trello ticket