-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable production-like logs if env variable is set #302
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've made a suggestion to the variable naming.
We'll also need to add an entry to the change log. With semantic versioning we should consider this a breaking change, which would seem a bit of a pain but given #300 already has breaking changes we can release them together and not need two major versions.
I'll leave a note on #300 to say to be careful with their version bump.
a323241
to
cdf808c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, I've made a couple of suggestions.
Thanks for GovukJsonLogging update ⭐
3b97267
to
155284b
Compare
This is to allow setting production-like behaviour by using an env variable. This env variable will be set in govuk-heml-charts repo. The purpose is to allow developers to override this env var in order to test changes to production logs locally.
155284b
to
5565808
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, thanks. I guess we can't release this until we've got the helm chart change applied to each env
@lauraghiorghisor-tw Can I double-check that alphagov/govuk-helm-charts#1190 adds the |
@floehopper Just saw this now, my apologies. Thank you for confirming this with someone else and bumping the version accordingly. 🙏🏻 Also, we identified a small issue that affects development, you might want to bump the version again. See PR here. |
This is to allow setting production-like behaviour by using the
ENABLE_PRODUCTION_LIKE_LOGS
env variable. This will be set ingovuk-heml-charts
->env-configmap.yaml
. The purpose is to allow developers to override this env var in order to test changes to production logs locally.Trello card