-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump govuk_app_config from 8.1.1 to 9.0.1 #2245
Conversation
This application is owned by the Access & Permissions team. Follow these steps if you are doing a Rails upgrade. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I want to check the changes to govuk-helm-charts
described in alphagov/govuk_app_config#302 have been made before we merge this.
I've asked about this in this comment. |
e05943a
to
5ca0b7b
Compare
5ca0b7b
to
874bcd0
Compare
@dependabot rebase |
Looks like this PR has been edited by someone other than Dependabot. That means Dependabot can't rebase it - sorry! If you're happy for Dependabot to recreate it from scratch, overwriting any edits, you can request |
Yo @floehopper - Did you make any changes when you force pushed this branch yesterday? I'm wondering whether it's safe to request |
No, I didn't - or at least not knowingly! How weird! 🤷 |
Thanks @floehopper. In which case I'll ask dependabot to recreate it. @dependabot recreate. |
Bumps [govuk_app_config](https://github.com/alphagov/govuk_app_config) from 8.1.1 to 9.0.1. - [Changelog](https://github.com/alphagov/govuk_app_config/blob/main/CHANGELOG.md) - [Commits](alphagov/govuk_app_config@v8.1.1...v9.0.1) --- updated-dependencies: - dependency-name: govuk_app_config dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]>
874bcd0
to
d565875
Compare
@chrislo has confirmed that the |
@dependabot rebase |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. See the comments in this PR for more info.
Superseded by #2256. |
Bumps govuk_app_config from 8.1.1 to 9.0.1.
Changelog
Sourced from govuk_app_config's changelog.
Commits
4fb9681
Merge pull request #306 from alphagov/fix-dropped-error-logs0524f39
Bump version 9.0.1990244e
Fix dropped logs due to incorrect error field typefb46270
Merge pull request #300 from alphagov/Log-GOVUK_REQUEST_ID-in-Json-in-Whitehall6408b62
Bump version 9.0.03f7a9b9
Update CHANGELOG.md5b80c3c
Remove Monkeypatchinge13795b
Log error in a full string instead of json0a6f772
Remove the rewiring stdout and strerr logic5836a2e
Change the default logger to include govuk_request_id.Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase
.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebase
will rebase this PR@dependabot recreate
will recreate this PR, overwriting any edits that have been made to it@dependabot merge
will merge this PR after your CI passes on it@dependabot squash and merge
will squash and merge this PR after your CI passes on it@dependabot cancel merge
will cancel a previously requested merge and block automerging@dependabot reopen
will reopen this PR if it is closed@dependabot close
will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot ignore this major version
will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor version
will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependency
will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)