Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump govuk_app_config from 8.1.1 to 9.0.1 #2245

Closed
wants to merge 1 commit into from

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jul 6, 2023

Bumps govuk_app_config from 8.1.1 to 9.0.1.

Changelog

Sourced from govuk_app_config's changelog.

9.0.1

  • Rename the "error" field in Rails logs from logstasher to "message" as error is supposed to be an object.

9.0.0

  • BREAKING: JSON logs are no longer configured automatically for production Rails apps and are turned on with the GOVUK_RAILS_JSON_LOGGING environment variable (#302)
  • Add govuk_request_id to JSON logging for apps with gds-api-adapters (#300)
  • BREAKING: Remove $stdout, $stderr and $real_stdout redirections (#300)
  • BREAKING: Change error log behaviour from logging JSON to full string (#300)
  • Remove monkeypatch for errors (#300)
Commits
  • 4fb9681 Merge pull request #306 from alphagov/fix-dropped-error-logs
  • 0524f39 Bump version 9.0.1
  • 990244e Fix dropped logs due to incorrect error field type
  • fb46270 Merge pull request #300 from alphagov/Log-GOVUK_REQUEST_ID-in-Json-in-Whitehall
  • 6408b62 Bump version 9.0.0
  • 3f7a9b9 Update CHANGELOG.md
  • 5b80c3c Remove Monkeypatching
  • e13795b Log error in a full string instead of json
  • 0a6f772 Remove the rewiring stdout and strerr logic
  • 5836a2e Change the default logger to include govuk_request_id.
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added dependencies ruby Pull requests that update Ruby code labels Jul 6, 2023
@github-actions
Copy link

github-actions bot commented Jul 6, 2023

This application is owned by the Access & Permissions team.

⚠️ This repo is Continuously Deployed: make sure you follow the guidance ⚠️

Follow these steps if you are doing a Rails upgrade.

@floehopper floehopper self-requested a review July 10, 2023 08:44
Copy link
Contributor

@floehopper floehopper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I want to check the changes to govuk-helm-charts described in alphagov/govuk_app_config#302 have been made before we merge this.

@floehopper
Copy link
Contributor

I want to check the changes to govuk-helm-charts described in alphagov/govuk_app_config#302 have been made before we merge this.

I've asked about this in this comment.

@dependabot dependabot bot force-pushed the dependabot/bundler/govuk_app_config-9.0.1 branch from e05943a to 5ca0b7b Compare July 10, 2023 09:12
@floehopper floehopper force-pushed the dependabot/bundler/govuk_app_config-9.0.1 branch from 5ca0b7b to 874bcd0 Compare July 10, 2023 09:41
@chrisroos
Copy link
Contributor

@dependabot rebase

@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Jul 11, 2023

Looks like this PR has been edited by someone other than Dependabot. That means Dependabot can't rebase it - sorry!

If you're happy for Dependabot to recreate it from scratch, overwriting any edits, you can request @dependabot recreate.

@chrisroos
Copy link
Contributor

Yo @floehopper - Did you make any changes when you force pushed this branch yesterday? I'm wondering whether it's safe to request @dependabot recreate so that it's clear we haven't made any changes.

@floehopper
Copy link
Contributor

@chrisroos

Did you make any changes when you force pushed this branch yesterday?

No, I didn't - or at least not knowingly! How weird! 🤷

@chrisroos
Copy link
Contributor

@chrisroos

Did you make any changes when you force pushed this branch yesterday?

No, I didn't - or at least not knowingly! How weird! shrug

Thanks @floehopper. In which case I'll ask dependabot to recreate it.

@dependabot recreate.

Bumps [govuk_app_config](https://github.com/alphagov/govuk_app_config) from 8.1.1 to 9.0.1.
- [Changelog](https://github.com/alphagov/govuk_app_config/blob/main/CHANGELOG.md)
- [Commits](alphagov/govuk_app_config@v8.1.1...v9.0.1)

---
updated-dependencies:
- dependency-name: govuk_app_config
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot force-pushed the dependabot/bundler/govuk_app_config-9.0.1 branch from 874bcd0 to d565875 Compare July 11, 2023 10:10
@chrisroos
Copy link
Contributor

I want to check the changes to govuk-helm-charts described in alphagov/govuk_app_config#302 have been made before we merge this.

I've asked about this in this comment.

@chrislo has confirmed that the GOVUK_RAILS_JSON_LOGGING environment variable has been set in staging and production for signon so I'm going to assume that we're safe to merge this now.

@chrisroos
Copy link
Contributor

@dependabot rebase

Copy link
Contributor

@chrisroos chrisroos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. See the comments in this PR for more info.

@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Jul 11, 2023

Superseded by #2256.

@dependabot dependabot bot closed this Jul 11, 2023
@dependabot dependabot bot deleted the dependabot/bundler/govuk_app_config-9.0.1 branch July 11, 2023 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies ruby Pull requests that update Ruby code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants