Extend layout for public with account components #2255
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danacotoran
force-pushed
the
public-layout-for-account
branch
from
5b9c2de
to
a76476d
Compare
danacotoran
force-pushed
the
public-layout-for-account
branch
from
a76476d
to
e720999
Compare
danacotoran
force-pushed
the
public-layout-for-account
branch
from
e720999
to
fcd6679
Compare
danacotoran
changed the title
danacotoran
changed the title
danacotoran
force-pushed
the
public-layout-for-account
branch
from
fcd6679
to
1286670
Compare
danacotoran
force-pushed
the
public-layout-for-account
branch
from
1286670
to
1d115ef
Compare
injms
reviewed
Aug 11, 2021
app/assets/stylesheets/govuk_publishing_components/components/_layout-for-public.scss
Show resolved
Hide resolved
injms
reviewed
Aug 11, 2021
app/views/govuk_publishing_components/components/_layout_for_public.html.erb
Show resolved
Hide resolved
injms
reviewed
Aug 11, 2021
app/views/govuk_publishing_components/components/_layout_for_public.html.erb
Outdated
Show resolved
Hide resolved
injms
approved these changes
Aug 11, 2021
danacotoran
force-pushed
the
public-layout-for-account
branch
from
1d115ef
to
364a7bb
Compare
andysellick
reviewed
Aug 11, 2021
app/views/govuk_publishing_components/components/_layout_for_public.html.erb
Outdated
Show resolved
Hide resolved
app/views/govuk_publishing_components/components/_layout_for_public.html.erb
Outdated
Show resolved
Hide resolved
app/views/govuk_publishing_components/components/_layout_for_public.html.erb
Outdated
Show resolved
Hide resolved
app/views/govuk_publishing_components/components/_layout_for_public.html.erb
Outdated
Show resolved
Hide resolved
app/views/govuk_publishing_components/components/_layout_for_public.html.erb
Outdated
Show resolved
Hide resolved
app/views/govuk_publishing_components/components/_layout_for_public.html.erb
Outdated
Show resolved
Hide resolved
andysellick
approved these changes
Aug 12, 2021
alex-ju
reviewed
Aug 12, 2021
app/assets/stylesheets/govuk_publishing_components/components/_layout-for-public.scss
Outdated
Show resolved
Hide resolved
app/views/govuk_publishing_components/components/_layout_for_public.html.erb
Show resolved
Hide resolved
danacotoran
force-pushed
the
public-layout-for-account
branch
from
cf06321
to
016e925
Compare
Update layout_for_public component to support GOVUK account components. Existing variations of the component will remain unchanged, but a few options have been introduced to support the main GOVUK account layout variations. The intention is for this to be used with a layout template in static, to apply account-like page furniture to pages that should have the account layout, while not being rendered by the govuk-account-manager-prototype app.
danacotoran
force-pushed
the
public-layout-for-account
branch
from
016e925
to
a474f81
Compare
injms
added a commit
that referenced
this pull request
Aug 12, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Update
layout_for_publiccomponent to support GOVUK Account components.Why
Some account-related components, contents, and CSS are repeated across different apps on GOVUK.
The first instance of this was when we relocated the account homepage from the govuk-account-manager-app to the frontend app, which meant that some of the page furniture and content was duplicated between those apps.
More recently, the accounts team are working towards the goal of single page notifications which will enable users who have linked their email notifications address and their GOVUK account email address to manage their email subscriptions through their account.
Part of this work is making the email management pages (rendered by
email-alert-frontend) look the same as the account manager when the user is authenticated with a linked account. Preview:That would make it three separate apps where page furniture and content are repeated to achieve the same layout.
The purpose of this PR is to extend
layout_for_publicso that it can be used as a "shell" for account (or "account-style" pages).Visual changes
Existing variations of the component will remain unchanged. A few options have been introduced to support the main GOVUK Account layout variations. The intention is for this to be used with a layout template in
static(or, in the case of thegovuk-account-manager-prototypeapp, be used directly in the application layout)Related:
static: Add new layout template for account-like pages static#2571email-alert-frontend: Account layout for email management pages email-alert-frontend#1106https://trello.com/c/F0ZDY0RC