Add new layout template for account-like pages #2571
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andysellick
reviewed
Aug 11, 2021
danacotoran
force-pushed
the
account-layout-wrapper-update
branch
from
d401f21
to
20cf0a2
Compare
danacotoran
force-pushed
the
account-layout-wrapper-update
branch
from
20cf0a2
to
7007997
Compare
andysellick
approved these changes
Aug 11, 2021
This adds a new account-related template, intended to be used on pages that should have the account layout, while not being rendered by the govuk-account-manager-prototype app. An example of such a page is the gov.uk/account/home page which was relocated from the account manager app to the frontend app, which at that time meant that some of the content and page furniture was duplicated between those applications. More recently, the accounts team are working towards the goal of single page notifications which will enable users who have linked their email notifications address and their GOVUK Account to manage their email subscriptions through their account. Part of this work is making the email management pages (which live in email-alert-frontend) look the same as the account manager when the user is authenticated with a linked account. Thanks to the changes included in this commit, we should be able to achieve this by simply requesting the gem_layout_account_manager from static, instead of copying individual components to yet another app.
danacotoran
force-pushed
the
account-layout-wrapper-update
branch
from
7007997
to
1e99551
Compare
danacotoran
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a new account-related template, intended to be used on pages that should have the account layout, while not being rendered by the
govuk-account-manager-prototypeapp.An example of such a page is the
gov.uk/account/homepage which was relocated from the account manager app to thefrontendapp, which at that time meant that some of the content and page furniture was duplicated between those applications.More recently, the accounts team are working towards the goal of single page notifications which will enable users who have linked their email notifications address and their GOVUK Account to manage their email subscriptions through their account.
Part of this work is making the email management pages (which live in
email-alert-frontend) look the same as the account manager when the user is authenticated with a linked account.Thanks to the changes included in this commit, we should be able to achieve this by simply requesting the
gem_layout_account_managerfromstatic, instead of copying individual components to yet another app.DO NOT MERGE: depends on alphagov/govuk_publishing_components#2255 (extendslayout_for_publicwith account componentshttps://trello.com/c/F0ZDY0RC