-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix print issues on layout-super-navigation-header #4165
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just wondering why the homepage doesn't have text?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just wondering is there a screenshot available of a GOV.UK page with the updated print styles?
Be good to see it within the context an end-user experiences it.
@nnagewad I did originally write some new print styles to ensure that all the headers looked the same with the same "GOV.UK" text next to the crown logo. However during review @andysellick suggested it wasn't necessary to do that since the homepage is an edge case where the "GOV.UK" text is part of the title content, and the crown is left as a single ident. The problem now is that by having the border underneath the crown/logo, it looks good for most pages but might look odd if the homepage is printed. |
@nnagewad I'll sort out a preview app of |
c0d8cf4
to
dd02ba2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me 👍
Have checked in frontend
as well, all looks okay.
@nnagewad Here's before/after screenshots of the revised top header bar. (Note there's some other print changes on these pages, but we're not looking at those in this PR.) Standard PageHomepage |
This looks really good. Just wondering, is it worth having the horizontal rule on the homepage? From your experience, how difficult will it be to remove it? |
dd02ba2
to
49bad0a
Compare
49bad0a
to
cadfb48
Compare
cadfb48
to
061a96f
Compare
@nnagewad This is updated now so that variants for the homepage will not show the border, and the logo is indented to align with the intro text below: |
Code has been updated to support a design change.
061a96f
to
29e2fe2
Compare
29e2fe2
to
9cc48dd
Compare
- Background should always print transparent - Foreground should always print black - Remove top border - Add bottom border to match new changes in cross service header - Remove left/right margins not required for print Note the use of the :has selector to remove the border and add a left indent only if the component contains the hidden 'GOV.UK' text. Variants that have hidden logo text are only used on the homepage, and need an adjusted design for print so that the crown logo lines up with the intro text below.
9cc48dd
to
ac51e19
Compare
What
The print styles on the layout-super-navigation-header are incorrect and need to be updated:
Trello
Why
Visual Changes
Before
After