Add taxonomy_topic_email_override to document collection schema #2440
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is an optional field that, if present, will contain the base path of the taxonomy that the document collection's email signup button should instead be used as the url to signup a user for email subscriptions.
This is part of work to retire specialist topics, and is being implemented specifically to support behaviour requested by HMRC for a small number of document collections that have been created to replace specialist topics. This field will not be present for the vast majority of document collections
BeckaL
force-pushed
the
email-signup-override
branch
from
3dbe3af
to
ffa093f
Compare
hannako
approved these changes
Aug 3, 2023
hannako
added a commit
that referenced
this pull request
Sep 1, 2023
In order for whitehall to publish document collections that contain taxonomy_topic_email_override in their links, the schema.json needs to contain the field, not just the links.json Adding the field to base links and regenerating the schemas only added it to links.json, so when trying to publish we are seeing schema validation errors: '#/links' contains additional properties [\"taxonomy_topic_email_override\"] outside of the schema when none are allowed Follows original PR: #2440
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an optional field that, if present, will contain the base path of the taxonomy that the document collection's email signup button should instead be used as the url to signup a user for email subscriptions.
This is part of work to retire specialist topics, and is being implemented specifically to support behaviour requested by HMRC for a small number of document collections that have been created to replace specialist topics. This field will not be present for the vast majority of document collections
Trello
This application is owned by the publishing platform team. Please let us know in #govuk-publishing-platform when you raise any PRs.
Follow these steps if you are doing a Rails upgrade.