UI to add a taxonomy topic email override to document collections #7950
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hannako
force-pushed
the
email-signup-override-for-doc-collections
branch
7 times, most recently
from
b9826df
to
74ff206
Compare
hannako
force-pushed
the
email-signup-override-for-doc-collections
branch
15 times, most recently
from
64a1a4d
to
4444b2b
Compare
hannako
changed the title
hannako
force-pushed
the
email-signup-override-for-doc-collections
branch
from
4444b2b
to
cba2303
Compare
This was referenced Aug 16, 2023
hannako
force-pushed
the
email-signup-override-for-doc-collections
branch
3 times, most recently
from
bce5500
to
9610fbb
Compare
hannako
force-pushed
the
email-signup-override-for-doc-collections
branch
from
9610fbb
to
001d361
Compare
hannako
force-pushed
the
email-signup-override-for-doc-collections
branch
10 times, most recently
from
1839e3d
to
5c87bcd
Compare
ryanb-gds
reviewed
Nov 27, 2023
There was a problem hiding this comment.
The more I look at this code the more I wonder if there should be a model to represent the TopicTaxonomyEmailOverride, backed by its own database table. I feel the logic is complex enough to justify it, even though the model would only have a few attributes. At the moment all of that logic is distributed across the controller, a presenter and some helpers, which makes it harder to reason about than it would be if it were all in one location. Also, it feels like we're arm-wrestling Rails a bit to make it do validation via flash messages, which to me is a good indication that we're missing a model. What do you think?
test/functional/admin/document_collection_email_subscriptions_controller_test.rb
Outdated
Show resolved
Hide resolved
ryanb-gds
approved these changes
Nov 27, 2023
This adds a basic edit and view method.
This will only display when the user has the relevant permission.
- This commit contains a placeholder implementation of the taxonomy topic select, using hardcoded values. It will be replaced in a subsequent commit.
When setting an email override field, a user must select a topic, and check a confirmation box. If they do both of those things, they will be redirected to the document collection edit page. It will only be possible to set and email override on a draft document collection. This restriction will be added in subsequent commit.
Attempting to set an email override field on a document that has already been published will raise a validation error. Update the controller to handle this exception. This error is not shown to the user as a flash, because in the next commit, we make it impossible to access the document collection email subscription edit forms for published document collections.
When a document collection is published, we will not allow the email override field to be edited. Users clicking the email notifications tab for a published document collection will see a summary, instead of the form.
If editing a draft document collection that already has a taxonomy_topic_email value assigned, select the relevant radio button and topic from the drop down when the page loads. If a user doesn't sumbit all the required values, and presses save they are redirected back, and shown an error. We should still retain their previous selections if any were made.
hannako
force-pushed
the
email-signup-override-for-doc-collections
branch
from
5c87bcd
to
b5a0a78
Compare
- the select-with-search component already exists in this application, and supports grouped items i.e. multiple things in a single row of the select.
hannako
force-pushed
the
email-signup-override-for-doc-collections
branch
from
b5a0a78
to
88a6f9c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contains work done by @BeckaL and @hannako
What
Add a new tab to the document collection edit view, to all publishers (with a special signon permission), to set a taxonomy_topic_email_override field on their document collection.
Example content item created from using this UI on integration to publish a collection:
Why
We (Homepage and Navigation Team) are retiring specialist topic pages i.e. we are redirecting all specialist topics to other pieces of content on GOV.UK and then removing support for specialist topics from the code base. One dept would like their specialist topics redirected to document collections, but they want the email signup button on those document collection pages to behave differently:
How
nil, which on the frontend will result in the page getting a standard single page notification buttonlinks.Related PR's upon which this work depends:
Future work
Once this feature has been used by the department to publish their collection pages, we will:
Trello
Follow these steps if you are doing a Rails upgrade.