Delete placeholder translations #2445
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkempster34
force-pushed
the
732-delete-placeholder-translations
branch
3 times, most recently
from
0472b24
to
0d3dea9
Compare
jkempster34
force-pushed
the
732-delete-placeholder-translations
branch
from
0d3dea9
to
5e5dd69
Compare
brucebolt
approved these changes
Jul 13, 2023
jkempster34
force-pushed
the
732-delete-placeholder-translations
branch
from
5e5dd69
to
34134d1
Compare
These placeholder translations get automatically expanded into the `available_translations` for their content item, but they are not valid for display, so they cause errors when using government-frontend to render worldwide organisations. Co-authored-by: Cristina <[email protected]>
This method was renamed in the past (#683), but the relevant documentation still has the old method name. Co-authored-by: Cristina <[email protected]>
CristinaRO
force-pushed
the
732-delete-placeholder-translations
branch
from
34134d1
to
f77d62a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://trello.com/c/xxdiO4lZ
Delete placeholder translations
These placeholder translations get automatically expanded into the
available_translationsfor their content item, but they are not valid fordisplay, so they cause errors when using government-frontend to render
worldwide organisations.
Fix method name in outdated documentation
This method was renamed in the past (#683), but the relevant documentation
still has the old method name.
This application is owned by the publishing platform team. Please let us know in #govuk-publishing-platform when you raise any PRs.
Follow these steps if you are doing a Rails upgrade.