Implement the ROS2 sink for the TextLogging #587
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Cool! I was a bit confused as ROS2 internally uses spdlog as well, but as explained in https://answers.ros.org/question/361736/what-is-the-intention-of-using-spdlog-under-the-hood/ the backend of the logging can be different, so it make sense to have this sink as no spdlog detail of ROS2 is exposed in the public API. |
traversaro
reviewed
Jan 27, 2023
src/TextLogging/RosImplementation/include/BipedalLocomotion/TextLogging/RosLogger.h
Outdated
Show resolved
Hide resolved
GiulioRomualdi
force-pushed
the
ros/text_logging
branch
2 times, most recently
from
d3eaee4
to
46b2e7c
Compare
GiulioRomualdi
force-pushed
the
ros/text_logging
branch
from
46b2e7c
to
b6d6f5d
Compare
…ntation for the text logging class
GiulioRomualdi
force-pushed
the
ros/text_logging
branch
from
200f0aa
to
b0c6684
Compare
S-Dafarra
approved these changes
Feb 3, 2023
|
macOS failure is fixed by #597 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will allow using the ros2 text logging mechanism within blf framework. Moreover, it also exposes the blf logging capabilities in the python bindings
cc @traversaro