Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement the ROS2 sink for the TextLogging #587

Merged
merged 5 commits into from
Feb 3, 2023
Merged

Conversation

GiulioRomualdi
Copy link
Member

@GiulioRomualdi GiulioRomualdi commented Jan 26, 2023

This PR will allow using the ros2 text logging mechanism within blf framework. Moreover, it also exposes the blf logging capabilities in the python bindings

cc @traversaro

@traversaro
Copy link
Collaborator

Cool! I was a bit confused as ROS2 internally uses spdlog as well, but as explained in https://answers.ros.org/question/361736/what-is-the-intention-of-using-spdlog-under-the-hood/ the backend of the logging can be different, so it make sense to have this sink as no spdlog detail of ROS2 is exposed in the public API.

@GiulioRomualdi GiulioRomualdi force-pushed the ros/text_logging branch 2 times, most recently from d3eaee4 to 46b2e7c Compare February 3, 2023 11:33
@GiulioRomualdi
Copy link
Member Author

macOS failure is fixed by #597

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants