Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor integrators module and redefine JaxSimModel class attributes #252

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

flferretti
Copy link
Collaborator

@flferretti flferretti commented Oct 3, 2024

This pull request includes several changes to the integrators logic and API. The JaxSimModel class now incorporates integrator and dt as static attributes. In order to do this, it was necessary to refactor the jaxsim.integrators module in order to simplify the logic by removing the init method.

The integrators logic is simplified by avoiding the use of integrator_state to pass around variables and making wrap_system_dynamics_for_integration accept only the function describing the dynamics of the system, since model and data were required arguments for the integration anyway.


📚 Documentation preview 📚: https://jaxsim--252.org.readthedocs.build//252/

@flferretti flferretti self-assigned this Oct 3, 2024
@flferretti flferretti force-pushed the feature/static_integrator_dt branch 2 times, most recently from 99878f7 to 3a1e965 Compare October 4, 2024 10:23
@flferretti flferretti marked this pull request as ready for review October 4, 2024 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant