Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix userId is overwritten by deviceId and make reset public #33

Merged
merged 1 commit into from
Jan 20, 2023
Merged

fix: fix userId is overwritten by deviceId and make reset public #33

merged 1 commit into from
Jan 20, 2023

Conversation

yuhao900914
Copy link
Contributor

Summary

This pr is for fixing the following issue.

  1. UserId is overriden by deviceId #32
  2. reset() is not marked public #31

Checklist

  • [ x ] Does your PR title have the correct title format?
  • Does your PR have a breaking change?:

@yuhao900914 yuhao900914 merged commit 4f49720 into main Jan 20, 2023
@yuhao900914 yuhao900914 deleted the issue-fix branch January 20, 2023 18:24
github-actions bot pushed a commit that referenced this pull request Feb 14, 2023
@amplitude-sdk-bot
chore(release): 0.3.1 [skip ci]
c71dd44 
## [0.3.1](v0.3.0...v0.3.1) (2023-02-14)

### Bug Fixes

* fix userId is overwritten by deviceId and make reset public ([#33](#33)) ([4f49720](4f49720))
* remove serverUrl as default value for configuration ([#34](#34)) ([48d0921](48d0921))
@github-actions
Copy link

🎉 This PR is included in version 0.3.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liuyang1520 liuyang1520 liuyang1520 approved these changes

@qingzhuozhen qingzhuozhen Awaiting requested review from qingzhuozhen

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yuhao900914 @liuyang1520