fix: remove serverUrl as default value for configuration #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liuyang1520
reviewed
Feb 9, 2023
liuyang1520
approved these changes
Feb 14, 2023
|
🎉 This PR is included in version 0.3.1 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
I fixed a small issue related to the EU server zone.
The code below doesn't work, because u still use DEFAULT_API_HOST
let amplitude = Amplitude( Configuration( apiKey: "YOUR-API-KEY", serverZone: ServerZone.EU ) )You could double-check HttpClient.getUrl(). It always uses configuration.serverUrl if it's not empty. So the default serverUrl value should be empty to solve this issue.
Currently, I'm using your lib for EU server zone. And made a workaround from my side:
let amplitude = Amplitude( Configuration( apiKey: "YOUR-API-KEY", serverZone: ServerZone.EU, serverUrl: "" ) )