Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move service getters to static class functions #10460

Merged
merged 4 commits into from
Jul 17, 2017
Merged

Move service getters to static class functions #10460

merged 4 commits into from
Jul 17, 2017

Conversation

dreamofabear
Copy link

@dreamofabear dreamofabear commented Jul 14, 2017 •
edited
Loading

Fixes #10128.

  • No logic changes.
  • Should be safe since this was done mechanically with find/replace and the methods are type-checked.
  • I'm so sorry.

@dreamofabear dreamofabear changed the title Services class Move service getters to new Services class Jul 14, 2017
@dreamofabear
Copy link
Author

/to @jridgewell

@dreamofabear dreamofabear changed the title Move service getters to new Services class Move service getters to static class functions Jul 15, 2017
@jridgewell
Copy link
Contributor

Merge conflicts. 😛

@dreamofabear
Copy link
Author

Fixed (for now)!

@dreamofabear
Copy link
Author

You da real mvp. 🙏

@dreamofabear dreamofabear merged commit 3b8c24b into ampproject:master Jul 17, 2017
@dreamofabear dreamofabear deleted the services-class branch July 17, 2017 19:49
This was referenced Aug 5, 2020
Closed
Closed
@samouri samouri mentioned this pull request Oct 18, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jridgewell jridgewell jridgewell approved these changes

Assignees
No one assigned
Labels
cla: yes PR use: In Beta / Experimental
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dreamofabear @jridgewell @googlebot @ampprojectbot