Services refactor #36400
Closed
Services refactor #36400
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samouri
force-pushed
the
services-refactor
branch
from
637df10
to
4ed66eb
Compare
|
Closing due to #36486 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
summary
Modifies
services/index.jsto be a series of top level exported functions instead of a class full of static functions. Essentially a revert of #10460.Addresses part of #35264 (comment), and #36453
why
Closure is able to optimize these whereas esbuild does not DCE the static funcs.
the big caveat
staticfunctions on a class are stubbable whereas namespace imports are not.This PR only passes because we use babel to transform to cjs modules before running tests.
I do not know if this is a good idea, but we need to come up with some way to DCE unused code.
results