Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

<amp-selector> element toggle the 'selected' attribute #13553

Merged
merged 17 commits into from
Feb 26, 2018
Merged

<amp-selector> element toggle the 'selected' attribute #13553

merged 17 commits into from
Feb 26, 2018

Commits on Feb 20, 2018

  1. WIP

    @nainar
    nainar committed Feb 20, 2018
    Configuration menu
    Copy the full SHA
    6ddfed6 View commit details
    Browse the repository at this point in the history

  2. Finalize implementation and tests

    @nainar
    nainar committed Feb 20, 2018
    Configuration menu
    Copy the full SHA
    524a18a View commit details
    Browse the repository at this point in the history

  3. Implementation and tests

    @nainar
    nainar committed Feb 20, 2018
    Configuration menu
    Copy the full SHA
    bf28c8d View commit details
    Browse the repository at this point in the history

Commits on Feb 21, 2018

  1. Make cvializ@ suggestions - change input argument name and clean up code

    @nainar
    nainar committed Feb 21, 2018
    Configuration menu
    Copy the full SHA
    2d3bd60 View commit details
    Browse the repository at this point in the history

  2. Cater for large negative numbers and add tests to check for that too

    @nainar
    nainar committed Feb 21, 2018
    Configuration menu
    Copy the full SHA
    33f521e View commit details
    Browse the repository at this point in the history

  3. Merge upstream

    @nainar
    nainar committed Feb 21, 2018
    Configuration menu
    Copy the full SHA
    4ec3718 View commit details
    Browse the repository at this point in the history

  4. Rewrite code and tests to be cleaner

    @nainar
    nainar committed Feb 21, 2018
    Configuration menu
    Copy the full SHA
    bfd6e11 View commit details
    Browse the repository at this point in the history

  5. Move mod functionality to helper and add tests too

    @nainar
    nainar committed Feb 21, 2018
    Configuration menu
    Copy the full SHA
    a848f21 View commit details
    Browse the repository at this point in the history

  6. Merge branch 'amp_selector_actions' into amp_selector_toggle

    @nainar
    nainar committed Feb 21, 2018
    Configuration menu
    Copy the full SHA
    6c8031d View commit details
    Browse the repository at this point in the history

  7. Merge branch 'master' of github.com:ampproject/amphtml into amp_selec… 

    …tor_actions
    @nainar
    nainar committed Feb 21, 2018
    Configuration menu
    Copy the full SHA
    29b52d8 View commit details
    Browse the repository at this point in the history

  8. Merge branch 'amp_selector_actions' into amp_selector_toggle

    @nainar
    nainar committed Feb 21, 2018
    Configuration menu
    Copy the full SHA
    e51d475 View commit details
    Browse the repository at this point in the history

Commits on Feb 22, 2018

  1. Remove unnecessary attribute logic

    @nainar
    nainar committed Feb 22, 2018
    Configuration menu
    Copy the full SHA
    861554f View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' of github.com:ampproject/amphtml into amp_selec… 

    …tor_actions
    @nainar
    nainar committed Feb 22, 2018
    Configuration menu
    Copy the full SHA
    79f93c7 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'amp_selector_actions' into amp_selector_toggle

    @nainar
    nainar committed Feb 22, 2018
    Configuration menu
    Copy the full SHA
    6f988ae View commit details
    Browse the repository at this point in the history

Commits on Feb 23, 2018

  1. Add assert to ensure index is > 0

    @nainar
    nainar committed Feb 23, 2018
    Configuration menu
    Copy the full SHA
    d043d7f View commit details
    Browse the repository at this point in the history

Commits on Feb 24, 2018

  1. Add additional assert

    @nainar
    nainar committed Feb 24, 2018
    Configuration menu
    Copy the full SHA
    c6c85cb View commit details
    Browse the repository at this point in the history

  2. Linter error

    @nainar
    nainar authored Feb 24, 2018
    Configuration menu
    Copy the full SHA
    0cb7e6b View commit details
    Browse the repository at this point in the history