-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
<amp-selector> element toggle the 'selected' attribute #13553
Merged
Merged
Changes from all commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
6ddfed6
WIP
nainar 524a18a
Finalize implementation and tests
nainar bf28c8d
Implementation and tests
nainar 2d3bd60
Make cvializ@ suggestions - change input argument name and clean up code
nainar 33f521e
Cater for large negative numbers and add tests to check for that too
nainar 4ec3718
Merge upstream
nainar bfd6e11
Rewrite code and tests to be cleaner
nainar a848f21
Move mod functionality to helper and add tests too
nainar 6c8031d
Merge branch 'amp_selector_actions' into amp_selector_toggle
nainar 29b52d8
Merge branch 'master' of github.com:ampproject/amphtml into amp_selec…
nainar e51d475
Merge branch 'amp_selector_actions' into amp_selector_toggle
nainar 861554f
Remove unnecessary attribute logic
nainar 79f93c7
Merge branch 'master' of github.com:ampproject/amphtml into amp_selec…
nainar 6f988ae
Merge branch 'amp_selector_actions' into amp_selector_toggle
nainar d043d7f
Add assert to ensure index is > 0
nainar c6c85cb
Add additional assert
nainar 0cb7e6b
Linter error
nainar File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The
!!
shouldn't be necessary here, since value and indexCurrentStatus are already boolean.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done