Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add crossorigin=anonymous to inserted script #25262

Merged
merged 1 commit into from
Oct 25, 2019

Conversation

zhouyx
Copy link
Contributor

@zhouyx zhouyx commented Oct 25, 2019

add crossorigin=anonymous to auto inserted script so that error information from those extensions can be reported.

related to #7353

Copy link
Contributor

@jridgewell jridgewell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@zhouyx zhouyx merged commit 40fa29d into ampproject:master Oct 25, 2019
@zhouyx zhouyx deleted the crossorigin-auto-insert branch October 25, 2019 22:27
micajuine-ho pushed a commit to micajuine-ho/amphtml that referenced this pull request Dec 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants